From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45431)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1UFR28-0003zR-GP
	for qemu-devel@nongnu.org; Tue, 12 Mar 2013 11:22:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1UFR23-0000Lu-5R
	for qemu-devel@nongnu.org; Tue, 12 Mar 2013 11:22:32 -0400
Received: from greensocs.com ([87.106.252.221]:56587
	helo=s15328186.onlinehome-server.info)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <fred.konrad@greensocs.com>) id 1UFR22-0000Lm-W5
	for qemu-devel@nongnu.org; Tue, 12 Mar 2013 11:22:27 -0400
Message-ID: <513F482E.1000106@greensocs.com>
Date: Tue, 12 Mar 2013 16:22:22 +0100
From: =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>
MIME-Version: 1.0
References: <1363080131-16427-1-git-send-email-fred.konrad@greensocs.com>
	<1363080131-16427-3-git-send-email-fred.konrad@greensocs.com>
	<CAFEAcA-1M_SbAGqdX7RT83s6MSdopMBGP9dgGpF+5jzWQnYEzg@mail.gmail.com>
	<513F3DAF.8050405@greensocs.com>
	<CAFEAcA9RrTFNs_tCqqCRowQs93GoiC3gG1SYenUhd7shy9mZCQ@mail.gmail.com>
	<513F44E7.2020306@greensocs.com>
	<CAFEAcA-1hdqHBEGBG+3fVFuLJj6EVLr++KHCUMkAKBEn77nyKA@mail.gmail.com>
In-Reply-To: <CAFEAcA-1hdqHBEGBG+3fVFuLJj6EVLr++KHCUMkAKBEn77nyKA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk
	device.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, aliguori@us.ibm.com, mst@redhat.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, afaerber@suse.de

On 12/03/2013 16:12, Peter Maydell wrote:
> On 12 March 2013 15:08, KONRAD Fr=C3=A9d=C3=A9ric <fred.konrad@greensoc=
s.com> wrote:
>> On 12/03/2013 15:42, Peter Maydell wrote:
>>> Yes, I see your problem there, but DEFINE_VIRTIO_BLK_SCSI_PROPERTY
>>> and DEFINE_DATA_PLANE_PROPERTIES are just convenience macros, not
>>> ones that are expected to be used by other code, right? So you can
>>> define them with commas (and name them something so it's obvious
>>> they're not intended for wider use as property array elements),
>>> and then just make sure your public-facing DEFINE_VIRTIO_BLK_PROPERTI=
ES
>>> doesn't end with a comma. (You can do that by putting the macros
>>> that expand to maybe-comma-or-not at the front, not the end.)
>>>
>>> -- PMM
>> ok, I can put a comment which say not to use them?
> And suitable macro names (ie not ones which look like all
> the other DEFINE_FOO_PROPERTIES ones). Alternatively since the
> macro's only used once as far as I can see, you could just not
> bother to abstract it out. The virtio-ccw blk properties still
> just have inline #ifdefs for the scsi prop for instance.
>
> -- PMM

The macro is used for virtio-blk device and virtio-blk-pci.
s390x devices don't use the same properties.