From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFRrm-0008Vx-3k for qemu-devel@nongnu.org; Tue, 12 Mar 2013 12:16:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFRrf-0004tz-R3 for qemu-devel@nongnu.org; Tue, 12 Mar 2013 12:15:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFRrf-0004tn-KQ for qemu-devel@nongnu.org; Tue, 12 Mar 2013 12:15:47 -0400 Message-ID: <513F5485.7060908@redhat.com> Date: Tue, 12 Mar 2013 10:15:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363000996-13221-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1363000996-13221-2-git-send-email-xiawenc@linux.vnet.ibm.com> <513E1934.4030908@redhat.com> <513EB6B3.9050609@linux.vnet.ibm.com> In-Reply-To: <513EB6B3.9050609@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2BUIAQCSKBQSEGEBVSQLH" Subject: Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2BUIAQCSKBQSEGEBVSQLH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/11/2013 11:01 PM, Wenchao Xia wrote: > =E4=BA=8E 2013-3-12 1:49, Eric Blake =E5=86=99=E9=81=93: >> On 03/11/2013 05:23 AM, Wenchao Xia wrote: >>> This patch adds block/snapshot.c and then moves the function >>> there. It also fixes small code style errors reported by check script= =2E >>> >>> + * This work is licensed under the terms of the GNU LGPL, version 2 >>> or later. >> >> Furthermore, the code you are moving was under BSD license, so by movi= ng >> the code, you have changed its license to something more restrictive. >> Personally, I like LGPL better than BSD, but as I'm not the copyright >> holder of the original code, and neither are you, I'm not sure that >> either of us is qualified to make that change. Therefore, I'm unwilli= ng >> to add my Reviewed-by, even though the code motion itself is correct, >> without a maintainer chiming in on whether your licensing is appropria= te >> or needs an adjustment. >> > Oops, Since it belongs to block layer I hope it can be LGPL2. Do you > know how to contact Fabrice Bellard to ask for a change? As far as I can tell, there is nothing wrong with leaving the file as BSD licensed instead of trying to insist that it be LGPL. The block layer will still be [L]GPL because of other files linked together, but there is nothing inherently wrong with linking a BSD file into an [L]GPL product. In other words, if you are okay with keeping the existing looser BSD license on this file only, it still won't change the license of the overall block layer, and it would save you the hassle of tracking down earlier authors to ask for a relicense. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2BUIAQCSKBQSEGEBVSQLH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRP1SFAAoJEKeha0olJ0NqiWwH/iu5pdXCm5+pNGjCj/NHjxMk XvPj1MMsMJqTpUqZUYFRpGoCet06xVyEwEXkz73CU3EtVUAaDBKdacZRBloO2NgU S2WUzjgs3U1mWFWqrx44eKbGAWt8DliL4l1sO7PwI/pg92pqaZj3rDBXFC6bJZS0 sbNYrbojx1+F8wH7AO3w7o/ECxNOI5/j5Xl4T0B/xNxf5FdrVQrHoh03k9RC4THb HJOBX68IC/dwh4d09zY7PnHBiAOcINNBmyNw+MMaiDo833dBsvWxYIVSGEE5lmDE vzw2C7S+6OQuwngtoEtOhBhQJjcbKdyRXs60HH4lR/0t47ub72LRvWxMdojb2Uo= =WzDp -----END PGP SIGNATURE----- ------enig2BUIAQCSKBQSEGEBVSQLH--