From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFRsu-0001zb-Gh for qemu-devel@nongnu.org; Tue, 12 Mar 2013 12:17:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFRsq-0005AG-97 for qemu-devel@nongnu.org; Tue, 12 Mar 2013 12:17:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFRsq-00058Z-1g for qemu-devel@nongnu.org; Tue, 12 Mar 2013 12:17:00 -0400 Message-ID: <513F54EE.1050205@redhat.com> Date: Tue, 12 Mar 2013 10:16:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363000996-13221-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20130312100754.GC19624@stefanha-thinkpad.redhat.com> In-Reply-To: <20130312100754.GC19624@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2SMAPMKUHIRPNLPPKBVDW" Subject: Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, pbonzini@redhat.com, Wenchao Xia This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2SMAPMKUHIRPNLPPKBVDW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/12/2013 04:07 AM, Stefan Hajnoczi wrote: > On Mon, Mar 11, 2013 at 07:23:02PM +0800, Wenchao Xia wrote: >> In the use of snapshot a way to retrieve related info at runtime is = needed, >> so this serial of patches will merge some code for qemu and qemu-img, = and add >> following interfaces for qemu: >> > Is there a reason you added the new query-images command instead of > extending BlockDeviceInfo with an ImageInfo field? Then query-block, > which is already used today, just provides ImageInfo as well. >=20 > I suggest this because it makes life easier for clients - they can issu= e > a single command to extract all image information. If we have two > commands they may have to invoke both and then match the results > together. Indeed, from the libvirt perspective, I would much prefer that a single command gives me everything, instead of having to call two commands to build up the complete picture. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2SMAPMKUHIRPNLPPKBVDW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRP1TuAAoJEKeha0olJ0Nqt8oH/2pIfT0NI1fVZnfizemfrZrT iAPTFAjLO5HXgjLloOvoJWeu6P6brE5dVBVEtza2m4YhXCYS3YflqDrHGVyxZkaa QtbN8tRao249NanCfZSYBpKxR4EEgA9t2rzOTt6uY//kWYHFlhwwOgH5V0wpas59 92ifGf51yTYapJHoacWbwUgWVP/vfqtukcvdvTpRDZ/WcxO+e64i92Oq4rDZWDeh QqDqlylUr8j0HuJxEHOxdKdVYlvpaG53oUAhA3YOJ6T3O19mwhXfSwf8xMlzjRJJ f/5dk+pP7K+p7Bs9MKn5y/B6UhN07rrcBg263Fg2CxLeQfrapfydiRoIACaJVSg= =hcvn -----END PGP SIGNATURE----- ------enig2SMAPMKUHIRPNLPPKBVDW--