Re: [Qemu-devel] [PATCH V9 04/14] block: move collect_snapshots() and collect_image_info() to block/qapi.c

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

On 03/11/2013 05:23 AM, Wenchao Xia wrote:
>   This patch adds block/qapi.c and moves the functions there. To avoid
> conflict and tip better, macro in header file is BLOCK_QAPI_H instead
> of QAPI_H. The moving is for making review easier, those functions
> will be modified and renamed later.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  block/Makefile.objs  |    2 +-
>  block/qapi.c         |   96 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  include/block/qapi.h |   24 ++++++++++++
>  qemu-img.c           |   86 ++-------------------------------------------
>  4 files changed, 124 insertions(+), 84 deletions(-)
>  create mode 100644 block/qapi.c
>  create mode 100644 include/block/qapi.h
> 

> +++ b/block/qapi.c
> @@ -0,0 +1,96 @@
> +/*
> + * Block layer qmp related functions
> + *
> + * Copyright IBM, Corp. 2013
> + *
> + * Authors:
> + *  Wenchao Xia   <xiawenc@linux.vnet.ibm.com>
> + *
> + * This work is licensed under the terms of the GNU LGPL, version 2 or later.
> + * See the COPYING.LIB file in the top-level directory.

This is another case of moving code from a BSD file into an LGPLv2+
file; depending on what the resolution is for 1/14, you should do the
same thing here.

Everything else looks okay, but I'm reluctant to add reviewed-by without
the license issue sorted.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]