From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFVHz-0004FU-Rx for qemu-devel@nongnu.org; Tue, 12 Mar 2013 15:59:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFV5I-0000TF-7u for qemu-devel@nongnu.org; Tue, 12 Mar 2013 15:43:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFV5I-0000T9-0J for qemu-devel@nongnu.org; Tue, 12 Mar 2013 15:42:04 -0400 Message-ID: <513F84FA.10707@redhat.com> Date: Tue, 12 Mar 2013 13:41:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363000996-13221-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1363000996-13221-5-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1363000996-13221-5-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2MWRQREXBLEVCMHKIAHSF" Subject: Re: [Qemu-devel] [PATCH V9 04/14] block: move collect_snapshots() and collect_image_info() to block/qapi.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2MWRQREXBLEVCMHKIAHSF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/11/2013 05:23 AM, Wenchao Xia wrote: > This patch adds block/qapi.c and moves the functions there. To avoid > conflict and tip better, macro in header file is BLOCK_QAPI_H instead > of QAPI_H. The moving is for making review easier, those functions > will be modified and renamed later. >=20 > Signed-off-by: Wenchao Xia > --- > block/Makefile.objs | 2 +- > block/qapi.c | 96 ++++++++++++++++++++++++++++++++++++++++++= ++++++++ > include/block/qapi.h | 24 ++++++++++++ > qemu-img.c | 86 ++----------------------------------------= --- > 4 files changed, 124 insertions(+), 84 deletions(-) > create mode 100644 block/qapi.c > create mode 100644 include/block/qapi.h >=20 > +++ b/block/qapi.c > @@ -0,0 +1,96 @@ > +/* > + * Block layer qmp related functions > + * > + * Copyright IBM, Corp. 2013 > + * > + * Authors: > + * Wenchao Xia > + * > + * This work is licensed under the terms of the GNU LGPL, version 2 or= later. > + * See the COPYING.LIB file in the top-level directory. This is another case of moving code from a BSD file into an LGPLv2+ file; depending on what the resolution is for 1/14, you should do the same thing here. Everything else looks okay, but I'm reluctant to add reviewed-by without the license issue sorted. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2MWRQREXBLEVCMHKIAHSF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRP4T7AAoJEKeha0olJ0NqpKUH/RGiEQVAmfE42ecyBH6b1cuZ JjboU1d+uec7QDmbdds65scM6wOuybveJju0Pu1tKQXFm/RGcD4gI4k4AokVTrck H+t0ExEtbwnI9B4HUNd9IM1cRC4qbZFzPXT9S/6Hql4DVAe6oqDuITQzoKBE65cL 2KUsv9nP9R24HWyvpS4VvFGqCaXcbFERYks6/DSC3t2FaUAlp+bOhBeVbWtmeSPl vM+XaAtpSpjilrusbY+CbtXvtEf9Em22EGmt4I9dTfY1n2tokqCr8TwVej8Wnk1P hdl7x9uazoETGOumvMOVREYerWArp6JbnvrZ8rXzxlupZ2opBl3ALxsTu8xt8Qk= =fgNm -----END PGP SIGNATURE----- ------enig2MWRQREXBLEVCMHKIAHSF--