From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA121-0007RZ-Nk for qemu-devel@nongnu.org; Mon, 06 Jun 2016 16:21:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bA11x-00028z-G4 for qemu-devel@nongnu.org; Mon, 06 Jun 2016 16:21:53 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:35815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA11x-00028t-Bb for qemu-devel@nongnu.org; Mon, 06 Jun 2016 16:21:49 -0400 Received: by mail-qt0-x243.google.com with SMTP id 37so1897417qtc.2 for ; Mon, 06 Jun 2016 13:21:49 -0700 (PDT) Sender: Richard Henderson References: <1465209480-71364-1-git-send-email-rolnik@amazon.com> <5c2fb726-caf5-edaa-a27b-1ec0fd7dee8f@twiddle.net> From: Richard Henderson Message-ID: <513d53bd-582c-38e5-fe84-e3cf6be34080@twiddle.net> Date: Mon, 6 Jun 2016 13:21:46 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/9] 8bit AVR cores List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Rolnik Cc: QEMU Developers , Michael Rolnik On 06/06/2016 12:49 PM, Michael Rolnik wrote: > please advise. > I have the following warning. but all print_instn_XXX functions are declared > this way. > so, I am kind of confused. I can fix it, but the file won't look the same. > > WARNING: space prohibited between function name and open parenthesis '(' > #132: FILE: include/disas/bfd.h:424: > +int print_insn_avr (bfd_vma, disassemble_info*); > > You can simply drop this declaration, since you don't have a printer. Recall that I *do* want you to fall back to the default print_insn_od_target. One can then use ./script/disas-objdump.pl to get proper disassembly. r~