From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Jeff Cody <jcody@redhat.com>, Peter Lieven <pl@dlhnet.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight
Date: Wed, 13 Mar 2013 11:15:38 +0100 [thread overview]
Message-ID: <514051CA.5050206@redhat.com> (raw)
In-Reply-To: <20130313093145.GB2309@dhcp-200-207.str.redhat.com>
Il 13/03/2013 10:31, Kevin Wolf ha scritto:
> Isn't the real problem that I/O requests for _this_specific_ iscsi BDS
> must not be in flight? So what you reall need is bdrv_drain(iscsi_bs)?
>
> If I understand the code correctly, this boils down to:
>
> while (iscsi_process_flush(iscsilun)) {
> qemu_aio_wait();
> }
Yes, but this function is not doing a truncate at all. It is simply
updating the cached result of bdrv_getlength. I think it makes sense
that this function (which should not be truncate, but something else)
expects to be called with no pending requests. It shouldn't be its task
to drain them.
I'll look at fixing this as mentioned in the earlier thread.
Paolo
next prev parent reply other threads:[~2013-03-13 10:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 10:05 [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight Peter Lieven
2013-03-11 10:16 ` Paolo Bonzini
2013-03-11 10:19 ` Peter Lieven
2013-03-11 11:44 ` Paolo Bonzini
2013-03-11 11:52 ` Peter Lieven
2013-03-11 13:00 ` Paolo Bonzini
2013-03-13 9:31 ` Kevin Wolf
2013-03-13 10:15 ` Paolo Bonzini [this message]
2013-03-19 7:29 ` Peter Lieven
2013-03-19 9:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514051CA.5050206@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@dlhnet.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).