From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFkUI-0003yh-ML for qemu-devel@nongnu.org; Wed, 13 Mar 2013 08:09:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFkUA-0000im-VR for qemu-devel@nongnu.org; Wed, 13 Mar 2013 08:08:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFkUA-0000iT-O1 for qemu-devel@nongnu.org; Wed, 13 Mar 2013 08:08:46 -0400 Message-ID: <51406C4A.9090508@redhat.com> Date: Wed, 13 Mar 2013 06:08:42 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363144182-1016-1-git-send-email-jschopp@linux.vnet.ibm.com> <1363144182-1016-3-git-send-email-jschopp@linux.vnet.ibm.com> In-Reply-To: <1363144182-1016-3-git-send-email-jschopp@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2TMTVNOIBGWGUNGSBTFKQ" Subject: Re: [Qemu-devel] [PATCH 2/9] qapi_c_arrays.diff List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joel Schopp Cc: Paolo Bonzini , Michael Tsirkin , qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2TMTVNOIBGWGUNGSBTFKQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/12/2013 09:09 PM, Joel Schopp wrote: > Forward ported Mike's previously sent patch > (see http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05782.html= ) in my > series since it impelments a qapi array interface the ASN.1 BER visitor= needs. s/impelments/implements/ >=20 > Generally these will be serialized into lists, but the > representation can be of any form so long as it can > be deserialized into a single-dimension C array. >=20 > +++ b/include/qapi/visitor-impl.h > @@ -34,6 +34,10 @@ struct Visitor > void (*type_str)(Visitor *v, char **obj, const char *name, Error *= *errp); > void (*type_number)(Visitor *v, double *obj, const char *name, > Error **errp); > + void (*start_carray)(Visitor *v, void **obj, const char *name, > + size_t elem_count, size_t elem_size, Error **e= rrp); Indentation looks off. > +++ b/include/qapi/visitor.h > @@ -51,5 +51,9 @@ void visit_type_size(Visitor *v, uint64_t *obj, const= char *name, Error **errp); > void visit_type_bool(Visitor *v, bool *obj, const char *name, Error **= errp); > void visit_type_str(Visitor *v, char **obj, const char *name, Error **= errp); > void visit_type_number(Visitor *v, double *obj, const char *name, Erro= r **errp); > +void visit_start_carray(Visitor *v, void **obj, const char *name, > + size_t elem_count, size_t elem_size, Error **er= rp); Indentation. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2TMTVNOIBGWGUNGSBTFKQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRQGxKAAoJEKeha0olJ0NqFSsH/23ModkaX3OJ20JUgYUVQEGf LBODUWPadiVFhDT017FK20NxP0TzHkbUJE3P/wU7fVv59UmlJpMBsFuKZtSkbg/L MPHQ4ZqH5X7YqAQjTe/M15W7x2lVSoM/2NGv1wtYyfCtEIIiYDhNZckmBVShsoJi GO6ITTB3fsB6+jHCkqFRPK2ZQ8Y+5wr84D5we818CHZ8z0ZXEEuDE/CXn5N215Zo NH0dFxQtGu/Gv3vvKITNXOmj7edGSFVoPZRYozrzJudl4bCLBW/c89BUEWRrcxDh a/HK/Wao/ezr+tDLVIiv+NLGaOSDg7Z20mhgE4O0t0MsAPVGyGn0jbGmT98Sw+k= =KSfb -----END PGP SIGNATURE----- ------enig2TMTVNOIBGWGUNGSBTFKQ--