From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49819) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFmd1-0006vl-OJ for qemu-devel@nongnu.org; Wed, 13 Mar 2013 10:26:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UFmct-0005Lb-Tx for qemu-devel@nongnu.org; Wed, 13 Mar 2013 10:26:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UFmct-0005L7-Lg for qemu-devel@nongnu.org; Wed, 13 Mar 2013 10:25:55 -0400 Message-ID: <51408C70.7010603@redhat.com> Date: Wed, 13 Mar 2013 15:25:52 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1363169922-24335-1-git-send-email-kraxel@redhat.com> <87k3pbiiur.fsf@codemonkey.ws> In-Reply-To: <87k3pbiiur.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] chardev: add vte chardev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On 03/13/13 13:29, Anthony Liguori wrote: > Gerd Hoffmann writes: > >> Kill the dirty hack which hooks gtk vte initialization into the >> qemu consoles subsystem. The vte terminals are not related to qemu >> consoles at all. This simply doesn't belong there and it stands in >> the way when cleaning up the qemu consoles subsystem. So fix it >> up, quickly, before it sneaks into a release. > > > My only concern is that if someone had a command line like: > > qemu -serial stdio -monitor vc > > It now breaks with your series. Yes. I'm not worried. The switch to gtk is a pretty big one anyway with a bunch of user interface changes. If we want avoid surprises for the user at any cost we must not make gtk the default ui. Also: Once I'm done with the console cleanup it will be easy to make 'vc' actually work with gtk. > 'vc' is a graphical chardev and it should be up to what UI layer to > decide how to express it No. 'vc' is a DisplaySurface filled by the qemu terminal emulation. It's generic and works with any UI. 'vte' is a chardev data stream linked up to the gtk vte widget. Obviously works with gtk only. > What's the issue your having with console cleanup? It just doesn't fit into the QemuConsoles at all, and with multiple UI's active (such as gtk+vnc at the same time) it doesn't make sense any more. cheers, Gerd