From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:32984)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1UFoIr-0002cb-Tw
	for qemu-devel@nongnu.org; Wed, 13 Mar 2013 12:13:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1UFoIq-0004iQ-Nk
	for qemu-devel@nongnu.org; Wed, 13 Mar 2013 12:13:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17572)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1UFoIq-0004iM-Gp
	for qemu-devel@nongnu.org; Wed, 13 Mar 2013 12:13:20 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2DGDJ60013156
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 13 Mar 2013 12:13:19 -0400
Message-ID: <5140A664.1010507@redhat.com>
Date: Wed, 13 Mar 2013 17:16:36 +0100
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1363190315-23956-1-git-send-email-alevy@redhat.com>
In-Reply-To: <1363190315-23956-1-git-send-email-alevy@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd
 tracking destruction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com

Looks good,

Acked-by: Hans de Goede <hdegoede@redhat.com>

On 03/13/2013 04:58 PM, Alon Levy wrote:
> No change for 64 bit arches, but for 32 bit previously we zeroed half
> the surfaces cmd array, instead of all of it.
>
> Signed-off-by: Alon Levy <alevy@redhat.com>
> ---
>   hw/qxl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/qxl.c b/hw/qxl.c
> index ef69348..4cbab45 100644
> --- a/hw/qxl.c
> +++ b/hw/qxl.c
> @@ -226,7 +226,7 @@ static void qxl_spice_destroy_surfaces_complete(PCIQXLDevice *qxl)
>       trace_qxl_spice_destroy_surfaces_complete(qxl->id);
>       qemu_mutex_lock(&qxl->track_lock);
>       memset(qxl->guest_surfaces.cmds, 0,
> -           sizeof(qxl->guest_surfaces.cmds) * qxl->ssd.num_surfaces);
> +           sizeof(qxl->guest_surfaces.cmds[0]) * qxl->ssd.num_surfaces);
>       qxl->guest_surfaces.count = 0;
>       qemu_mutex_unlock(&qxl->track_lock);
>   }
>