From: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org,
lcapitulino@redhat.com, pbonzini@redhat.com,
Wenchao Xia <xiawenc@linux.vnet.ibm.com>,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH V9 04/14] block: move collect_snapshots() and collect_image_info() to block/qapi.c
Date: Wed, 13 Mar 2013 14:34:04 -0600 [thread overview]
Message-ID: <5140E2BC.509@redhat.com> (raw)
In-Reply-To: <513F84FA.10707@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 968 bytes --]
On 03/12/2013 01:41 PM, Eric Blake wrote:
> On 03/11/2013 05:23 AM, Wenchao Xia wrote:
>> This patch adds block/qapi.c and moves the functions there. To avoid
>> conflict and tip better, macro in header file is BLOCK_QAPI_H instead
>> of QAPI_H. The moving is for making review easier, those functions
>> will be modified and renamed later.
>>
>
> This is another case of moving code from a BSD file into an LGPLv2+
> file; depending on what the resolution is for 1/14, you should do the
> same thing here.
>
> Everything else looks okay, but I'm reluctant to add reviewed-by without
> the license issue sorted.
Same argument as for 1/14 - you exercised your right to copy code from a
permissive license into a stronger license, which is an acceptable use
of open source code. Hence:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-03-13 20:34 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-11 11:23 [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info Wenchao Xia
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c Wenchao Xia
2013-03-11 17:49 ` Eric Blake
2013-03-12 5:01 ` Wenchao Xia
2013-03-12 16:15 ` Eric Blake
2013-03-12 16:22 ` Eric Blake
2013-03-13 1:57 ` Wenchao Xia
2013-03-13 12:41 ` Kevin Wolf
2013-03-13 18:19 ` Markus Armbruster
2013-03-13 20:28 ` Eric Blake
2013-03-14 9:01 ` Kevin Wolf
2013-03-14 12:10 ` Markus Armbruster
2013-03-14 12:53 ` Kevin Wolf
2013-03-15 6:23 ` Wenchao Xia
2013-03-15 8:00 ` Kevin Wolf
2013-03-13 18:08 ` Markus Armbruster
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 02/14] block: distinguish id and name in bdrv_find_snapshot() Wenchao Xia
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 03/14] qemu-img: remove unused parameter in collect_image_info() Wenchao Xia
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 04/14] block: move collect_snapshots() and collect_image_info() to block/qapi.c Wenchao Xia
2013-03-12 19:41 ` Eric Blake
2013-03-13 20:34 ` Eric Blake [this message]
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 05/14] block: add snapshot info query function bdrv_query_snapshot_info_list() Wenchao Xia
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 06/14] block: add check for VM snapshot in bdrv_query_snapshot_info_list() Wenchao Xia
2013-03-12 19:45 ` Eric Blake
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 07/14] block: add image info query function bdrv_query_image_info() Wenchao Xia
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 08/14] qmp: add interface query-snapshots Wenchao Xia
2013-03-12 21:12 ` Eric Blake
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 09/14] qmp: add interface query-images Wenchao Xia
2013-03-12 21:24 ` Eric Blake
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 10/14] hmp: add function hmp_info_snapshots() Wenchao Xia
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 11/14] hmp: switch snapshot info function to qmp based one Wenchao Xia
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 12/14] block: move dump_human_image_info() to block/qapi.c Wenchao Xia
2013-03-13 20:38 ` Eric Blake
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 13/14] block: dump to buffer for bdrv_image_info_dump() Wenchao Xia
2013-03-11 11:23 ` [Qemu-devel] [PATCH V9 14/14] hmp: add command info images Wenchao Xia
2013-03-12 10:07 ` [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info Stefan Hajnoczi
2013-03-12 16:16 ` Eric Blake
2013-03-13 2:54 ` Wenchao Xia
2013-03-13 11:34 ` Stefan Hajnoczi
2013-03-13 12:29 ` Eric Blake
2013-03-13 12:35 ` Kevin Wolf
2013-03-13 12:40 ` Stefan Hajnoczi
2013-03-15 6:07 ` Wenchao Xia
2013-03-15 8:07 ` Kevin Wolf
2013-03-18 10:30 ` Wenchao Xia
2013-03-18 16:48 ` Kevin Wolf
2013-03-15 8:44 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140E2BC.509@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).