qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: mdroth <mdroth@linux.vnet.ibm.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	qemu-devel@nongnu.org, Liu Ping Fan <qemulist@gmail.com>,
	Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib
Date: Thu, 14 Mar 2013 11:53:19 +0100	[thread overview]
Message-ID: <5141AC1F.3030203@redhat.com> (raw)
In-Reply-To: <CAFEAcA8oX7U7KMz6rRyfxjUFXF22Aac3RPFG_hFnyRuY9d=2qw@mail.gmail.com>

Il 14/03/2013 11:04, Peter Maydell ha scritto:
> On 13 March 2013 12:34, Anthony Liguori <anthony@codemonkey.ws> wrote:
>> AioContext is necessary for the block layer because the block layer
>> still has synchronous I/O.  I think we should aim to replace all sync
>> I/O in the long term with coroutine based I/O.
> 
> I think coroutines are dreadful and we should really not be moving
> towards greater use of them. They're just really really not portable
> and they don't fit with the C language, and they're a constant source
> of problems.(For instance I have a bug I need to look into where we
> seem to hang using the gthread coroutine backend but not sigaltstack.)

The gthread coroutine backend is really more for debugging than anything
else.  It works for qemu-io/img, but not for QEMU.  Good that you
actually found proof. :)

Paolo

> Use threads, or a genuinely asynchronous API, or a select/poll loop
> with callbacks, but not more coroutines please.
> 
> -- PMM
> 

  reply	other threads:[~2013-03-14 10:53 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13  5:59 [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib Liu Ping Fan
2013-03-13  5:59 ` [Qemu-devel] [RFC PATCH 1/2] net: port tap " Liu Ping Fan
2013-03-13  5:59 ` [Qemu-devel] [RFC PATCH 2/2] net: port hub " Liu Ping Fan
2013-03-13 10:58 ` [Qemu-devel] [RFC PATCH 0/2] port network layer " Paolo Bonzini
2013-03-13 12:34   ` Anthony Liguori
2013-03-13 16:21     ` Paolo Bonzini
2013-03-13 17:06       ` mdroth
2013-03-13 17:31         ` Paolo Bonzini
2013-03-13 17:52           ` Michael S. Tsirkin
2013-03-13 18:09             ` Anthony Liguori
2013-03-13 17:23       ` Anthony Liguori
2013-03-13 17:35         ` Paolo Bonzini
2013-03-13 17:52           ` Anthony Liguori
2013-03-14  9:29             ` Stefan Hajnoczi
2013-03-14  9:53               ` Paolo Bonzini
2013-03-13 17:58           ` Anthony Liguori
2013-03-13 18:08             ` Paolo Bonzini
2013-03-13 18:51               ` Anthony Liguori
2013-03-14 10:04     ` Peter Maydell
2013-03-14 10:53       ` Paolo Bonzini [this message]
2013-03-14 11:00         ` Peter Maydell
2013-03-14 11:04           ` Paolo Bonzini
2013-03-14 11:26             ` Peter Maydell
2013-03-15  9:13       ` Stefan Hajnoczi
2013-03-19  9:30       ` Markus Armbruster
2013-03-19 10:12         ` Peter Maydell
2013-03-19 10:34           ` Paolo Bonzini
2013-03-19 10:38             ` Peter Maydell
2013-03-19 10:45               ` Paolo Bonzini
2013-03-14 14:08   ` liu ping fan
2013-03-14 14:18     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5141AC1F.3030203@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemulist@gmail.com \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).