From: Laszlo Ersek <lersek@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable
Date: Thu, 14 Mar 2013 16:52:04 +0100 [thread overview]
Message-ID: <5141F224.3010108@redhat.com> (raw)
In-Reply-To: <1363273057-25850-1-git-send-email-kwolf@redhat.com>
On 03/14/13 15:57, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> After rebasing this I saw that Anthony already committed a fix that is
> very close to my v1. I don't intend to actually change that code, but as
> I've already done this, just for comparison what it would look like with
> error propagation. Is this what you meant? I find the result more
> confusing, to be honest.
I think what I had in mind was:
- I was okay with the logic change you suggested in your v1, just
- turn *errp accesses into local_err accesses,
- when returning, propagate the latter to the former.
The logic seemed OK, I just suggested to keep the massage internal to
the function, only try to propagate it outwards at return time. IOW,
never read *errp.
Laszlo
next prev parent reply other threads:[~2013-03-14 15:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 10:48 [Qemu-devel] [PATCH] qemu-sockets: Fix assertion failure Kevin Wolf
2013-03-06 11:04 ` Paolo Bonzini
2013-03-06 11:11 ` Kevin Wolf
2013-03-06 14:46 ` Laszlo Ersek
2013-03-06 15:04 ` Paolo Bonzini
2013-03-06 15:19 ` Kevin Wolf
2013-03-06 15:38 ` Laszlo Ersek
2013-03-06 15:47 ` Kevin Wolf
2013-03-06 16:04 ` Laszlo Ersek
2013-03-06 15:59 ` Markus Armbruster
2013-03-06 16:43 ` Paolo Bonzini
2013-03-14 14:57 ` [Qemu-devel] [RFC PATCH] qemu-socket: Use local error variable Kevin Wolf
2013-03-14 15:52 ` Laszlo Ersek [this message]
2013-03-15 8:37 ` Kevin Wolf
2013-03-15 16:55 ` Laszlo Ersek
2013-03-15 17:55 ` Kevin Wolf
2013-03-15 18:39 ` Laszlo Ersek
2013-03-19 20:34 ` [Qemu-devel] [PATCH] qemu-sockets: Fix assertion failure Luiz Capitulino
2013-03-20 8:39 ` Kevin Wolf
2013-03-20 12:57 ` Luiz Capitulino
2013-03-20 13:37 ` Kevin Wolf
2013-03-20 13:52 ` Luiz Capitulino
2013-03-06 15:05 ` Markus Armbruster
2013-03-06 15:05 ` [Qemu-devel] Error ** parameter conventions (was: [PATCH] qemu-sockets: Fix assertion failure) Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5141F224.3010108@redhat.com \
--to=lersek@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).