From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGB5Z-0003zz-Tp for qemu-devel@nongnu.org; Thu, 14 Mar 2013 12:33:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGB5W-0006OV-0M for qemu-devel@nongnu.org; Thu, 14 Mar 2013 12:33:09 -0400 Received: from mel.act-europe.fr ([194.98.77.210]:40525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGB5V-0006OP-N7 for qemu-devel@nongnu.org; Thu, 14 Mar 2013 12:33:05 -0400 Message-ID: <5141FBC0.6050905@adacore.com> Date: Thu, 14 Mar 2013 17:33:04 +0100 From: Fabien Chouteau MIME-Version: 1.0 References: <1363109492-1901-1-git-send-email-chouteau@adacore.com> <1363109492-1901-4-git-send-email-chouteau@adacore.com> <87mwu6z7ze.fsf@blackfin.pond.sub.org> <5141AD9B.3060702@adacore.com> <8738vyw46r.fsf@blackfin.pond.sub.org> In-Reply-To: <8738vyw46r.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 3/3] New option -gdb-opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org On 03/14/2013 01:34 PM, Markus Armbruster wrote: > Fabien Chouteau writes: > >> On 03/14/2013 09:44 AM, Markus Armbruster wrote: >>> Fabien Chouteau writes: >>> >>>> We introduce a new command line option. It's a generic option to >>>> customize the gdb server: >>>> >>>> -gdb-opts [attached=on|off] >>>> >>>> The only parameter for now is "attached". >>>> >>>> Signed-off-by: Fabien Chouteau >>> >>> --gdb-opts complements existing --gdb. You need to use both for full >>> control. >>> >>> I figure you do this because you can't extend --gdb, as its argument is >>> in legacy character device syntax, not QemuOpts. >>> >> >> That's right, maybe we can do some string manipulations to handle this case. >> >> -gdb tcp::1234,attached=off >> >> find ',attached={on|off}' and remove it from the string. > > That way is madness :) Come on, you've seen worse ;) >>> We had similar cases before, and solved them differently: create a more >>> general option, then make the old one sugar for the new one. >>> >>> For instance, --monitor and --qmp are sugar for --mon. Desugaring code >>> is in monitor_parse(). >>> >> >> Something like: >> >> -chardev socket,id=gdb1,host=localhost,port=1234,server,nowait,nodelay >> -gdb-remote chardev=gdb1,attached=off >> >> You still need two options for full control. > > Yes, but following precedence is good. Our command line is inconsistent > enough as it is. Just my two cents. > Fair enough, lets forget about the option this is too much work. I'll just tweak the sources on our branch. Regards, -- Fabien Chouteau