From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGEBc-00068c-4b for qemu-devel@nongnu.org; Thu, 14 Mar 2013 15:51:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGEBW-0003bv-QO for qemu-devel@nongnu.org; Thu, 14 Mar 2013 15:51:36 -0400 Received: from goliath.siemens.de ([192.35.17.28]:34350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGEBW-0003bd-Gr for qemu-devel@nongnu.org; Thu, 14 Mar 2013 15:51:30 -0400 Message-ID: <51422A3D.7000308@siemens.com> Date: Thu, 14 Mar 2013 20:51:25 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1363109492-1901-1-git-send-email-chouteau@adacore.com> <1363109492-1901-2-git-send-email-chouteau@adacore.com> In-Reply-To: <1363109492-1901-2-git-send-email-chouteau@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH v4] Add GDB qAttached support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: "qemu-devel@nongnu.org" , Fabien Chouteau With this patch QEMU handles qAttached request from gdb. When QEMU replies 1, GDB sends a "detach" command at the end of a debugging session otherwise GDB sends "kill". The default value for qAttached is 1 on system emulation and 0 on user emulation. Based on original version by Fabien Chouteau. Signed-off-by: Jan Kiszka --- As Fabien dropped his attempt to make this configurable, let's preserve the value of exposing this feature to gdb statically. gdbstub.c | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index e414ad9..9daee86 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -42,6 +42,12 @@ #include "sysemu/kvm.h" #include "qemu/bitops.h" +#ifdef CONFIG_USER_ONLY +#define GDB_ATTACHED "0" +#else +#define GDB_ATTACHED "1" +#endif + #ifndef TARGET_CPU_MEMORY_RW_DEBUG static inline int target_memory_rw_debug(CPUArchState *env, target_ulong addr, uint8_t *buf, int len, int is_write) @@ -2491,6 +2497,10 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) break; } #endif + if (strncmp(p, "Attached", 8) == 0) { + put_packet(s, GDB_ATTACHED); + break; + } /* Unrecognised 'q' command. */ goto unknown_command; -- 1.7.3.4