From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGFz9-0005BM-5N for qemu-devel@nongnu.org; Thu, 14 Mar 2013 17:46:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGFz7-0005mZ-U2 for qemu-devel@nongnu.org; Thu, 14 Mar 2013 17:46:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGFz7-0005mR-LG for qemu-devel@nongnu.org; Thu, 14 Mar 2013 17:46:49 -0400 Message-ID: <51424546.40801@redhat.com> Date: Thu, 14 Mar 2013 15:46:46 -0600 From: Eric Blake MIME-Version: 1.0 References: <1362867748-30528-1-git-send-email-stefanha@redhat.com> <1362867748-30528-5-git-send-email-stefanha@redhat.com> In-Reply-To: <1362867748-30528-5-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2RDGBFLTNREGPAWFSIHJT" Subject: Re: [Qemu-devel] [RFC 4/8] block: add block_backup QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Markus Armbruster , qemu-devel@nongnu.org, dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2RDGBFLTNREGPAWFSIHJT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/09/2013 03:22 PM, Stefan Hajnoczi wrote: > @block-backup >=20 > Start a point-in-time copy of a block device to a new destination. >=20 Is a BLOCK_JOB_COMPLETED event emitted when the copy is completed? If not, it should be. > +# Since 1.5 > +## > +{ 'command': 'block-backup', > + 'data': { 'device': 'str', 'target': 'str', '*format': 'str', > + '*mode': 'NewImageMode', '*speed': 'int' } } This creates a new job type - do you need to update other locations (such as BlockJobInfo's @type, and in QMP/qmp-events.txt under BLOCK_JOB_CANCELLED/BLOCK_JOB_COMPLETED @type) to call out what string is used for the new job type? For that matter, is it finally time to introduce a new enum type for all valid block job types, and use that enum type instead of 'str' anywhere QMP data structures distinguish based on job type? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2RDGBFLTNREGPAWFSIHJT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRQkVGAAoJEKeha0olJ0NqG44H/2Y11LK9QiAQqd3WipHXhH4w tCP9hQy9TWnwVCBpQhfXNRKV6LJDO0NmhEtix+bKTaj+BlMNjQV7CCClT3ZBz1dj lYILnj+5ABu7qfjdr2boT9QTd35NAKs7uR2AL93+FVVx/6IKe//kB6BHieibM1OW okEpm+bPn3bv6J7Uv59pk843rkb9XM1ANIVFVpA7kfSgG1/yUD4tC+EHYORVasEF UTdCXKOSETYuQr7wbRtmo9+kcd5r0QrtIHV+eGzpodGxnEjPI2Iaa0Rl+VsEKacg 7GAO7deP3TAydET3F+sLnkXJpOxeuCAw2ry2Zpt+66dWDA5W7RjUNSxBHcrtkmI= =5hWi -----END PGP SIGNATURE----- ------enig2RDGBFLTNREGPAWFSIHJT--