From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGKxL-0004P7-JK for qemu-devel@nongnu.org; Thu, 14 Mar 2013 23:05:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGKxG-00037b-Hn for qemu-devel@nongnu.org; Thu, 14 Mar 2013 23:05:19 -0400 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:53011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGKxF-00036m-W1 for qemu-devel@nongnu.org; Thu, 14 Mar 2013 23:05:14 -0400 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 15 Mar 2013 12:58:31 +1000 Received: from d23relay05.au.ibm.com (d23relay05.au.ibm.com [9.190.235.152]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 14DBC3578050 for ; Fri, 15 Mar 2013 14:05:06 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2F2pdfT9961684 for ; Fri, 15 Mar 2013 13:51:40 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2F34YHE030074 for ; Fri, 15 Mar 2013 14:04:34 +1100 Message-ID: <51428FB5.20606@linux.vnet.ibm.com> Date: Fri, 15 Mar 2013 11:04:21 +0800 From: Lei Li MIME-Version: 1.0 References: <1363273553-29111-1-git-send-email-lilei@linux.vnet.ibm.com> <20130314214125.GD9093@vm> In-Reply-To: <20130314214125.GD9093@vm> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2 v6] Add Windows support for time resync by qemu-ga List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 03/15/2013 05:41 AM, mdroth wrote: > On Thu, Mar 14, 2013 at 11:05:51PM +0800, Lei Li wrote: >> This patch series attempts to add Windows implementation >> for qemu-ga commands guest-get-time and guest-set-time. >> >> The previous thread about the interfaces introduced and >> the POSIX-specific command implementation has already >> been accepted, the reference link: >> >> http://article.gmane.org/gmane.comp.emulators.qemu/198472 >> >> Notes: >> Now It was tested on Windows XP SP3 and Windows 7. >> Please comment! > Series looks good other than comment in patch 1. I can fix this in tree > or you can send another version. I am very sorry for this, I should check the rest of it... :-( Sure, I will submit new version with this fixed. Thanks for your time! > > Reviewed-by: Michael Roth > >> Thanks. >> >> Changes since v5: >> - Fix the error check for GetSystemTime() from Michael. >> - Other fixups from Michael. >> >> Changes since v4: >> - Error handel improvement from Michael. >> - Do the math explicitly for the time convert of FILETIME >> suggested by Michael. >> >> Changes since v3: >> - Reorder the acquire_privilege to avoid a possible >> leak of privileges suggested by Eric. >> >> Changes since v2: >> - Overflow check improvement for time_ns from Eric. >> >> Changes since v1: >> - Make the macro for the offset between windows baseline >> and Unix Epoch more readable from Eric. >> - Overflow check for filetime pointed by Eric. >> >> Lei Li (2): >> qga: add windows implementation for guest-get-time >> qga: add windows implementation for guest-set-time >> -- Lei