From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGO4a-0005DF-0p for qemu-devel@nongnu.org; Fri, 15 Mar 2013 02:25:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UGO4Y-00029F-Sp for qemu-devel@nongnu.org; Fri, 15 Mar 2013 02:24:59 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:41079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UGO4Y-00027g-6O for qemu-devel@nongnu.org; Fri, 15 Mar 2013 02:24:58 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 15 Mar 2013 11:51:19 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 9E00C3940023 for ; Fri, 15 Mar 2013 11:54:52 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2F6OkQN11534846 for ; Fri, 15 Mar 2013 11:54:47 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2F6OooC006818 for ; Fri, 15 Mar 2013 17:24:51 +1100 Message-ID: <5142BE70.7020307@linux.vnet.ibm.com> Date: Fri, 15 Mar 2013 14:23:44 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1363000996-13221-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1363000996-13221-2-git-send-email-xiawenc@linux.vnet.ibm.com> <513E1934.4030908@redhat.com> <513EB6B3.9050609@linux.vnet.ibm.com> <20130313124128.GG2309@dhcp-200-207.str.redhat.com> <87li9r9n8f.fsf@blackfin.pond.sub.org> <20130314090141.GB2485@dhcp-200-207.str.redhat.com> <87mwu6w5a4.fsf@blackfin.pond.sub.org> <20130314125334.GD2485@dhcp-200-207.str.redhat.com> In-Reply-To: <20130314125334.GD2485@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: lcapitulino@redhat.com, stefanha@gmail.com, pbonzini@redhat.com, Markus Armbruster , qemu-devel@nongnu.org 于 2013-3-14 20:53, Kevin Wolf 写道: > Am 14.03.2013 um 13:10 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >>> But you have to do it right. This specific patch would introduce a >>> copyright violation. It's really not that hard to conform to the terms >>> of the MIT license, but that doesn't mean that you can ignore it. There >>> is exactly one requirement and it reads like this: >>> >>> The above copyright notice and this permission notice shall be >>> included in all copies or substantial portions of the Software. >> >> That's why I pointed to resources and examples on how to do it properly. >> >>> (I'm still waiting for a patch to blockdev.c, for which you did it >>> wrong, by the way) >> >> Oops, that one fell through the cracks. Patch coming. > > Thanks. > >>>> Of course, the stronger license still has to be compatible with GPLv2, >>>> so we can accept the result into QEMU. >>>> >>>> If a subsystem has additional requirements on licenses, its maintainers >>>> will explain them to you. For what it's worth, substantial parts of the >>>> block layer are already GPLv2+. >>> >>> What parts exactly? As long as there are plans for a libqblock and as >>> long as it doesn't seem completely impossible to have it under LGPL, I >>> will ask to use either MIT or LGPL for block layer code (this doesn't >>> apply to qemu-only code that isn't used in the tools - in this sense, >>> things like blockdev.c are not part of the block layer) >> >> $ git-grep -lw GPL block block* >> block-migration.c >> block/blkverify.c >> block/gluster.c >> block/linux-aio.c >> block/raw-aio.h >> block/rbd.c >> block/sheepdog.c >> blockdev-nbd.c >> blockdev.c > > Luckily, none of these are really critical for a libqblock library, even > though they would be nice to have. > > If we can't license such a library as LGPL, we would lose the most > important potential user, which is libvirt. In which case I probably > wouldn't want to bother with providing a library at all. > > Kevin > As the discuss, I feel a direct copy of the license is the easiest way, the original one is a good enough MIT license, if my understanding is correct. One more question: should the date be changed to 2003-2013 in new file? /* * QEMU System Emulator * * Copyright (c) 2003-2008 Fabrice Bellard ..... -- Best Regards Wenchao Xia