From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60055)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UGXM2-0000lp-Su
	for qemu-devel@nongnu.org; Fri, 15 Mar 2013 12:19:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UGXM0-0008PM-AT
	for qemu-devel@nongnu.org; Fri, 15 Mar 2013 12:19:37 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37483)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UGXM0-0008NB-2h
	for qemu-devel@nongnu.org; Fri, 15 Mar 2013 12:19:36 -0400
Message-ID: <51434A11.9020904@redhat.com>
Date: Fri, 15 Mar 2013 17:19:29 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1363358063-23973-1-git-send-email-peter.maydell@linaro.org>
	<51434591.2060203@redhat.com>
	<CAFEAcA_fr_VGoVm3eun8PintuGY4=cFJ08sO2p4YKY5+R581Mg@mail.gmail.com>
In-Reply-To: <CAFEAcA_fr_VGoVm3eun8PintuGY4=cFJ08sO2p4YKY5+R581Mg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and
	sysbus_del_memory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Michael Walle <michael@walle.cc>, Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, patches@linaro.org

Il 15/03/2013 17:09, Peter Maydell ha scritto:
> On 15 March 2013 16:00, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 15/03/2013 15:34, Peter Maydell ha scritto:
>>> I rather suspect sysbus_add_io and sysbus_del_io should also be
>>> removed, but since their users are in PPC and x86 platforms I'll
>>> let somebody else do that part :-)
>>
>> sysbus_add_io and sysbus_del_io are actually a good match for the I/O
>> address space of x86, because the model was to have "well-known" port
>> numbers standardized across all platforms.  So all the boards would have
>> to know those port addresses if we used sysbus_init_mmio.
> 
> Maybe they should just call memory_region_add_subregion()
> directly then? There's nothing sysbus-device-specific about
> what these functions do, they just take a SysBusDevice* and
> totally ignore it...

It affects the OpenFirmware path, but perhaps we can move the
get_fw_dev_path from the Bus to the Device class.

Paolo