From: "Sebastian Herbszt" <herbszt@gmx.de>
To: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org
Cc: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [6392] Add BIOS fixes from KVM tree
Date: Thu, 22 Jan 2009 23:51:28 +0100 [thread overview]
Message-ID: <5145212075BC479892B6FB212939F2E3@FSCPC> (raw)
In-Reply-To: <4978E1ED.90309@codemonkey.ws>
Anthony Liguori wrote:
> Marcelo Tosatti wrote:
>> On Thu, Jan 22, 2009 at 01:14:32AM +0100, Carl-Daniel Hailfinger wrote:
>>
>>> Hi,
>>>
>>> I'm sorry to say that, but my tests showed that
>>> 0004_kvm-bios-add-mtrr-support.patch is buggy. It reads MSR_MTRRcap
>>> unconditionally which is not allowed if the CPUID features do not have
>>> CPUID_MTRR set. Real hardware will #GP in that case.
>>> This was found by my MSR access tracing patch.
>>>
>>> Please add a check for the CPUID_MTRR feature bit before reading
>>> MSR_MTRRcap. Thanks.
>>>
>>
>> Attached, can you confirm it works for you, please?
>>
>
> Please work with Sebastian on this. I'll just pull this fix in from
> upstream Bochs once it's all integrated.
I sent a combined patch to the bochs mailing list. It is also available at [1].
[1] http://article.gmane.org/gmane.comp.emulators.bochs.devel/8256
- Sebastian
prev parent reply other threads:[~2009-01-22 22:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 21:46 [Qemu-devel] [6392] Add BIOS fixes from KVM tree Anthony Liguori
2009-01-22 0:14 ` Carl-Daniel Hailfinger
2009-01-22 19:36 ` [Qemu-devel] " Sebastian Herbszt
2009-01-22 20:53 ` [Qemu-devel] " Marcelo Tosatti
2009-01-22 21:15 ` Anthony Liguori
2009-01-22 22:51 ` Sebastian Herbszt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5145212075BC479892B6FB212939F2E3@FSCPC \
--to=herbszt@gmx.de \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=c-d.hailfinger.devel.2006@gmx.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).