From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHVTk-0006KU-TI for qemu-devel@nongnu.org; Mon, 18 Mar 2013 04:31:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHVTe-00068o-Ln for qemu-devel@nongnu.org; Mon, 18 Mar 2013 04:31:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55314 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHVTe-00068Y-FT for qemu-devel@nongnu.org; Mon, 18 Mar 2013 04:31:30 -0400 Message-ID: <5146D0DE.7010300@suse.de> Date: Mon, 18 Mar 2013 09:31:26 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1363161681-13878-1-git-send-email-lig.fnst@cn.fujitsu.com> <1363161681-13878-5-git-send-email-lig.fnst@cn.fujitsu.com> In-Reply-To: <1363161681-13878-5-git-send-email-lig.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH][RFC 04/14] qdev: add power on/off/suspend/wakeup handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liguang Cc: qemu-devel@nongnu.org, Anthony Liguori Am 13.03.2013 09:01, schrieb liguang: > Signed-off-by: liguang > --- > hw/qdev-core.h | 9 +++++ > hw/qdev.c | 96 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 105 insertions(+), 0 deletions(-) >=20 > diff --git a/hw/qdev-core.h b/hw/qdev-core.h > index e69c50b..805ac69 100644 > --- a/hw/qdev-core.h > +++ b/hw/qdev-core.h > @@ -262,6 +262,15 @@ void qdev_reset_all(DeviceState *dev); > void qbus_reset_all(BusState *bus); > void qbus_reset_all_fn(void *opaque); > =20 > +void qdev_power_on(DeviceState *dev); > +void qdev_power_off(DeviceState *dev); > +void qdev_power_wakeup(DeviceState *dev); > +void qdev_power_suspend(DeviceState *dev); No new qdev_ functions please. qdev no longer exists in its original form since the QOM introduction. Please use device_ instead. Note that here you use power_*, so it may be worth using an identical callback field name for at least on and off if we go with your concept. Andreas > +void qbus_power_off(void *opaque); > +void qbus_power_wakeup(void *opaque); > +void qbus_power_suspend(void *opaque); > +void qbus_power_on(void *opaque); > + > void qbus_free(BusState *bus); > =20 > #define FROM_QBUS(type, dev) DO_UPCAST(type, qbus, dev) [snip] --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg