From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51617)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UHVkL-0004Kw-GI
	for qemu-devel@nongnu.org; Mon, 18 Mar 2013 04:48:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UHVkK-0003Pb-2W
	for qemu-devel@nongnu.org; Mon, 18 Mar 2013 04:48:45 -0400
Received: from mail-bk0-x232.google.com ([2a00:1450:4008:c01::232]:44164)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UHVkJ-0003PU-Pv
	for qemu-devel@nongnu.org; Mon, 18 Mar 2013 04:48:43 -0400
Received: by mail-bk0-f50.google.com with SMTP id jg9so2324299bkc.23
	for <qemu-devel@nongnu.org>; Mon, 18 Mar 2013 01:48:42 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5146D4E6.4080705@redhat.com>
Date: Mon, 18 Mar 2013 09:48:38 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1363576743-6146-1-git-send-email-mrhines@linux.vnet.ibm.com>
	<1363576743-6146-5-git-send-email-mrhines@linux.vnet.ibm.com>
In-Reply-To: <1363576743-6146-5-git-send-email-mrhines@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v4: 04/10] iterators for
 getting the RAMBlocks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: mrhines@linux.vnet.ibm.com
Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com

Il 18/03/2013 04:18, mrhines@linux.vnet.ibm.com ha scritto:
> From: "Michael R. Hines" <mrhines@us.ibm.com>
> 
> This introduces:
> 1. qemu_ram_foreach_block
> 2. qemu_ram_count_blocks
> 
> Both used in communicating the RAMBlocks
> to each side for later memory registration.
> 
> Signed-off-by: Michael R. Hines <mrhines@us.ibm.com>
> ---
>  exec.c                    |   21 +++++++++++++++++++++
>  include/exec/cpu-common.h |    6 ++++++
>  2 files changed, 27 insertions(+)
> 
> diff --git a/exec.c b/exec.c
> index 8a6aac3..a985da8 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -2629,3 +2629,24 @@ bool cpu_physical_memory_is_io(hwaddr phys_addr)
>               memory_region_is_romd(section->mr));
>  }
>  #endif
> +
> +void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque)
> +{
> +    RAMBlock *block;
> +
> +    QTAILQ_FOREACH(block, &ram_list.blocks, next) {
> +        func(block->host, block->offset, block->length, opaque);
> +    }
> +}
> +
> +int qemu_ram_count_blocks(void)
> +{
> +    RAMBlock *block;
> +    int total = 0;
> +
> +    QTAILQ_FOREACH(block, &ram_list.blocks, next) {
> +        total++;
> +    }

Please move this to rdma.c, and implement it using qemu_ram_foreach_block.

Otherwise looks good.

Paolo

> +    return total;
> +}
> diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h
> index 2e5f11f..aea3fe0 100644
> --- a/include/exec/cpu-common.h
> +++ b/include/exec/cpu-common.h
> @@ -119,6 +119,12 @@ extern struct MemoryRegion io_mem_rom;
>  extern struct MemoryRegion io_mem_unassigned;
>  extern struct MemoryRegion io_mem_notdirty;
>  
> +typedef void  (RAMBlockIterFunc)(void *host_addr, 
> +    ram_addr_t offset, ram_addr_t length, void *opaque); 
> +
> +void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque);
> +int qemu_ram_count_blocks(void);
> +
>  #endif
>  
>  #endif /* !CPU_COMMON_H */
>