From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHdBm-00074S-Ax for qemu-devel@nongnu.org; Mon, 18 Mar 2013 12:45:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHdBk-00058C-PJ for qemu-devel@nongnu.org; Mon, 18 Mar 2013 12:45:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53969 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHdBk-00057o-H3 for qemu-devel@nongnu.org; Mon, 18 Mar 2013 12:45:32 -0400 Message-ID: <514744A8.4020702@suse.de> Date: Mon, 18 Mar 2013 17:45:28 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1363624238-29121-1-git-send-email-peter.maydell@linaro.org> <1363624238-29121-2-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1363624238-29121-2-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] arm_gic: Fix sizes of state fields in preparation for vmstate support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, patches@linaro.org Am 18.03.2013 17:30, schrieb Peter Maydell: > In preparation for switching to vmstate for migration support, fix > the sizes of various GIC state fields. In particular, we replace all > the bitfields (which VMState can't deal with) with straightforward > uint8_t values which we do bit operations on. (The bitfields made > more sense when NCPU was set differently in different situations, > but we now always model at the architectural limit of 8.) >=20 > Signed-off-by: Peter Maydell [...] > diff --git a/hw/armv7m_nvic.c b/hw/armv7m_nvic.c > index d198cfd..b2a7fb7 100644 > --- a/hw/armv7m_nvic.c > +++ b/hw/armv7m_nvic.c > @@ -458,10 +458,10 @@ static void armv7m_nvic_reset(DeviceState *dev) > * as enabled by default, and with a priority mask which allows > * all interrupts through. > */ > - s->gic.cpu_enabled[0] =3D 1; > + s->gic.cpu_enabled[0] =3D false; true? Andreas > s->gic.priority_mask[0] =3D 0x100; > /* The NVIC as a whole is always enabled. */ > - s->gic.enabled =3D 1; > + s->gic.enabled =3D true; > systick_reset(s); > } > =20 >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg