From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHgcj-00019p-N2 for qemu-devel@nongnu.org; Mon, 18 Mar 2013 16:25:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHgcg-0002UD-O9 for qemu-devel@nongnu.org; Mon, 18 Mar 2013 16:25:37 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:53306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHgcg-0002U7-Ki for qemu-devel@nongnu.org; Mon, 18 Mar 2013 16:25:34 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 18 Mar 2013 16:25:34 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id A30ACC9001D for ; Mon, 18 Mar 2013 16:25:32 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2IKPWeI327300 for ; Mon, 18 Mar 2013 16:25:32 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2IKPW3D007479 for ; Mon, 18 Mar 2013 17:25:32 -0300 Message-ID: <5147783B.7080201@linux.vnet.ibm.com> Date: Mon, 18 Mar 2013 16:25:31 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <1363576743-6146-1-git-send-email-mrhines@linux.vnet.ibm.com> <1363576743-6146-5-git-send-email-mrhines@linux.vnet.ibm.com> <5146D4E6.4080705@redhat.com> In-Reply-To: <5146D4E6.4080705@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH RDMA support v4: 04/10] iterators for getting the RAMBlocks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com Acnkowledged. On 03/18/2013 04:48 AM, Paolo Bonzini wrote: > Il 18/03/2013 04:18, mrhines@linux.vnet.ibm.com ha scritto: >> From: "Michael R. Hines" >> >> This introduces: >> 1. qemu_ram_foreach_block >> 2. qemu_ram_count_blocks >> >> Both used in communicating the RAMBlocks >> to each side for later memory registration. >> >> Signed-off-by: Michael R. Hines >> --- >> exec.c | 21 +++++++++++++++++++++ >> include/exec/cpu-common.h | 6 ++++++ >> 2 files changed, 27 insertions(+) >> >> diff --git a/exec.c b/exec.c >> index 8a6aac3..a985da8 100644 >> --- a/exec.c >> +++ b/exec.c >> @@ -2629,3 +2629,24 @@ bool cpu_physical_memory_is_io(hwaddr phys_addr) >> memory_region_is_romd(section->mr)); >> } >> #endif >> + >> +void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque) >> +{ >> + RAMBlock *block; >> + >> + QTAILQ_FOREACH(block, &ram_list.blocks, next) { >> + func(block->host, block->offset, block->length, opaque); >> + } >> +} >> + >> +int qemu_ram_count_blocks(void) >> +{ >> + RAMBlock *block; >> + int total = 0; >> + >> + QTAILQ_FOREACH(block, &ram_list.blocks, next) { >> + total++; >> + } > Please move this to rdma.c, and implement it using qemu_ram_foreach_block. > > Otherwise looks good. > > Paolo > >> + return total; >> +} >> diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h >> index 2e5f11f..aea3fe0 100644 >> --- a/include/exec/cpu-common.h >> +++ b/include/exec/cpu-common.h >> @@ -119,6 +119,12 @@ extern struct MemoryRegion io_mem_rom; >> extern struct MemoryRegion io_mem_unassigned; >> extern struct MemoryRegion io_mem_notdirty; >> >> +typedef void (RAMBlockIterFunc)(void *host_addr, >> + ram_addr_t offset, ram_addr_t length, void *opaque); >> + >> +void qemu_ram_foreach_block(RAMBlockIterFunc func, void *opaque); >> +int qemu_ram_count_blocks(void); >> + >> #endif >> >> #endif /* !CPU_COMMON_H */ >> >