From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54755) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHql7-0007xW-Cu for qemu-devel@nongnu.org; Tue, 19 Mar 2013 03:14:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHql6-0004EW-0q for qemu-devel@nongnu.org; Tue, 19 Mar 2013 03:14:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHql5-0004EP-Oy for qemu-devel@nongnu.org; Tue, 19 Mar 2013 03:14:55 -0400 Message-ID: <51481067.3080007@redhat.com> Date: Tue, 19 Mar 2013 08:14:47 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1363628865-29390-1-git-send-email-peter.maydell@linaro.org> <1363628865-29390-3-git-send-email-peter.maydell@linaro.org> <51476DD1.6070705@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/2] hw/arm_gic_common: Use vmstate struct rather than save/load functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mitsyanko Cc: "qemu-devel@nongnu.org" , Peter Maydell , Michael Roth , Andreas , patches@linaro.org Hi, >> (vmstate.h is getting hugely repetitive to the point that I'm >> really tempted to say we should just autogenerate it. That way >> you could define a fairly small set of things (arrays, base types, >> safe vs unsafe, etc) and have a script generate the cross product, >> rather than the current setup where there is a lot of hand written >> repetition and a tendency to gaps in the coverage where nobody's >> using them yet.) > I can recall a qemu-devel discussion over a long-term QOM goals a while > ago.Somebody suggested that in the future we will define devices state > structures using some special macro which will be parsed during > compilation, serializing each member for both QOM introspection and vmstate > migration. That is where I see the future too. Michael Roth [ cc'ed ] has this on his agenda. We have code generation infrastructure for qapi and it surely makes sense to reuse that for vmstate. cheers, Gerd