From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57557) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHqzU-0004Px-RC for qemu-devel@nongnu.org; Tue, 19 Mar 2013 03:29:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHqzR-0000i6-Ne for qemu-devel@nongnu.org; Tue, 19 Mar 2013 03:29:48 -0400 Received: from ssl.dlhnet.de ([91.198.192.8]:40436 helo=ssl.dlh.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHqzR-0000hy-Hv for qemu-devel@nongnu.org; Tue, 19 Mar 2013 03:29:45 -0400 Message-ID: <514813EE.7080501@dlhnet.de> Date: Tue, 19 Mar 2013 08:29:50 +0100 From: Peter Lieven MIME-Version: 1.0 References: <513DAC5B.5000607@dlhnet.de> <513DAF15.4030000@redhat.com> In-Reply-To: <513DAF15.4030000@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Jeff Cody , "qemu-devel@nongnu.org" , Anthony Liguori On 11.03.2013 11:16, Paolo Bonzini wrote: > Il 11/03/2013 11:05, Peter Lieven ha scritto: >> ensure that there are no pending I/Os before calling >> the sync readcapacity commands. the block_resize monitor >> command will also flush all I/O, but double check in >> case iscsi_truncate() is called from elsewhere in the >> future. >> >> Signed-off-by: Peter Lieven >> --- >> block/iscsi.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/block/iscsi.c b/block/iscsi.c >> index 3d52921..de20d53 100644 >> --- a/block/iscsi.c >> +++ b/block/iscsi.c >> @@ -1167,6 +1167,10 @@ static int iscsi_truncate(BlockDriverState *bs, >> int64_t offset) >> return -ENOTSUP; >> } >> >> + /* ensure all async requests are completed before executing >> + * a sync readcapacity */ >> + bdrv_drain_all(); >> + >> if ((ret = iscsi_readcapacity_sync(iscsilun)) != 0) { >> return ret; >> } > > NACK to this patch. It would be a bug, let's fix it properly. > > The other two are fine, however. Paolo, can you ensure that Patch 1+2 get merged before qemu 1.5.0 to fix the regression. Thanks, Peter > > Paolo >