From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44687)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pl@dlhnet.de>) id 1UHrzB-0001RI-3u
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 04:33:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@dlhnet.de>) id 1UHrz8-0005Sm-AR
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 04:33:33 -0400
Received: from ssl.dlhnet.de ([91.198.192.8]:40888 helo=ssl.dlh.net)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@dlhnet.de>)
	id 1UHrz8-0005Sa-4S
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 04:33:30 -0400
Message-ID: <514822DF.6060302@dlhnet.de>
Date: Tue, 19 Mar 2013 09:33:35 +0100
From: Peter Lieven <pl@dlhnet.de>
MIME-Version: 1.0
References: <5146F57E.9010502@dlhnet.de> <8738vs50qb.fsf@blackfin.pond.sub.org>
	<5147337C.8030000@dlhnet.de> <87txo7pzi7.fsf@blackfin.pond.sub.org>
In-Reply-To: <87txo7pzi7.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] qemu segfault parsing iscsi options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <bonzini@gnu.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, ronnie sahlberg <ronniesahlberg@gmail.com>

On 19.03.2013 09:25, Markus Armbruster wrote:
> Peter Lieven <pl@dlhnet.de> writes:
>
>> On 18.03.2013 13:52, Markus Armbruster wrote:
>>> Peter Lieven <pl@dlhnet.de> writes:
>>>
>>>> Hi,
>>>>
>>>> with recent qemu from git qemu segfaults with the following commandline:
>>>>
>>>> x86_64-softmmu/qemu-system-x86_64 -iscsi test
>>>>
>>>> qemu-system-x86_64: -iscsi test: There is no option group 'iscsi'
>>>> Speicherzugriffsfehler (Speicherabzug geschrieben)
>>>>
>>>> It seems that there is something missing regarding the iscsi options
>>>> in qemu-option.hx.
>>>>
>>>> This was working with qemu-kvm-1.2.0.
>>>
>>> Works for me with current master 225dc991.
>>>
>>
>> for me it doesn't...
>>
>> ~/git/qemu$ git log -1 --oneline
>> 225dc99 s390: Fix cpu refactoring fallout.
>>
>> there is definetly missing some parts in qemu-options.hx for -iscsi
>
> Nope.  It's an initialization order issue.

yes, you are right. so Paolo's patch needs to be fixed. The patch
series fixes at least the iSCSI part.

>
> Paolo's commit 4d454574 "qemu-option: move standard option definitions
> out of qemu-config.c" moved option group registration from compile time
> (initializer of vm_config_groups[]) to run time (various places).
>
> Registration of group "iscsi" moved to iscsi_block_init(), a block
> driver initialization function.  These are run by
> bdrv_init_with_whitelist(), which gets called only after command line
> parsing.  Oops.
>
> I'm afraid we need to re-review all of that commit for similar
> initialization order errors.
>

 From a quick look at the code, it could be that -spice is broken.
-fsdev and -virtfs work.
I have not find any other invocations of qemu_add_opts outside vl.c

Peter.