From: Gerd Hoffmann <kraxel@redhat.com>
To: Alon Levy <alevy@redhat.com>
Cc: "Amit Shah" <amit.shah@redhat.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Marc-André Lureau" <mlureau@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post load
Date: Tue, 19 Mar 2013 10:28:58 +0100 [thread overview]
Message-ID: <51482FDA.9020105@redhat.com> (raw)
In-Reply-To: <395888904.10562585.1363684543684.JavaMail.root@redhat.com>
On 03/19/13 10:15, Alon Levy wrote:
>>> + vmstate_register(NULL, -1, &spice_chr_vmstate, s);
>>> +
>>
>> That is a showstopper. If there are two of these there is no
>> reliable
>> way to figure which is which.
>
> But they will both get a different state pointer s.
I mean in the migration data stream.
> It is being migrated in virtio-serial-bus (port->guest_connected)
> but we need to pass that on to spice-server, which there is no hook
> for in the chardev layer, I could add one. I would need to query the
> backend, in this case virtio-serial-bus, something like this:
That is better IMHO.
cheers,
Gerd
next prev parent reply other threads:[~2013-03-19 9:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 16:36 [Qemu-devel] Spice / usb-redir chardev flowcontrol patches v2 Hans de Goede
2013-03-14 16:36 ` [Qemu-devel] [PATCH 1/8] virtio-console: Also throttle when less was written then requested Hans de Goede
2013-03-14 16:36 ` [Qemu-devel] [PATCH 2/8] virtio-console: Remove any pending watches on close Hans de Goede
2013-03-18 12:16 ` Amit Shah
2013-03-14 16:36 ` [Qemu-devel] [PATCH 3/8] spice-qemu-char: Remove #ifdef-ed code for old spice-server compat Hans de Goede
2013-03-14 16:36 ` [Qemu-devel] [PATCH 4/8] spice-qemu-char: Add watch support Hans de Goede
2013-03-14 16:36 ` [Qemu-devel] [PATCH 5/8] spice-qemu-char: Remove intermediate buffer Hans de Goede
2013-03-14 16:36 ` [Qemu-devel] [PATCH 6/8] spice-qemu-char: Move spice_chr_close down Hans de Goede
2013-03-14 16:36 ` [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post load Hans de Goede
2013-03-19 7:05 ` Gerd Hoffmann
2013-03-19 9:15 ` Alon Levy
2013-03-19 9:28 ` Gerd Hoffmann [this message]
2013-03-14 16:36 ` [Qemu-devel] [PATCH 8/8] usb-redir: Add flow control support Hans de Goede
2013-03-19 12:40 ` Gerd Hoffmann
2013-03-19 13:54 ` Hans de Goede
2013-03-18 12:21 ` [Qemu-devel] Spice / usb-redir chardev flowcontrol patches v2 Amit Shah
2013-03-19 7:07 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51482FDA.9020105@redhat.com \
--to=kraxel@redhat.com \
--cc=alevy@redhat.com \
--cc=amit.shah@redhat.com \
--cc=hdegoede@redhat.com \
--cc=mlureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).