From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHt1p-0004EQ-5h for qemu-devel@nongnu.org; Tue, 19 Mar 2013 05:40:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHt1n-0004za-JX for qemu-devel@nongnu.org; Tue, 19 Mar 2013 05:40:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHt1n-0004zQ-B9 for qemu-devel@nongnu.org; Tue, 19 Mar 2013 05:40:19 -0400 Message-ID: <5148325F.6010603@redhat.com> Date: Tue, 19 Mar 2013 10:39:43 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20130312025854.GA4876@t430s.nay.redhat.com> <20130318132003.GA4153@t430s.nay.redhat.com> <20130319044915.GA1888@t430s.nay.redhat.com> In-Reply-To: <20130319044915.GA1888@t430s.nay.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] migrate cancel bug in latest qemu upstream List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, mst@redhat.com, quintela@redhat.com, qemu-devel , owasserm@redhat.com, juzhang@redhat.com Il 19/03/2013 05:49, Amos Kong ha scritto: > On Mon, Mar 18, 2013 at 09:20:03PM +0800, Amos Kong wrote: >> On Tue, Mar 12, 2013 at 10:58:54AM +0800, Amos Kong wrote: >>> Hi quintela, I found a migrate bug in Autotest result, not sure if >>> it's already known. > > This bug was already fixed by this patch: > > commit dba433c03a0f5dc22a459435dd89557886298921 > Author: Paolo Bonzini > Date: Fri Feb 22 17:36:17 2013 +0100 > > migration: simplify error handling > > Always use qemu_file_get_error to detect errors, since that is how > QEMUFile itself drops I/O after an error occurs. There is no need > to propagate and check return values all the time. > > Also remove the "complete" member, since we know that it is set (via > migrate_fd_cleanup) only when the state changes. > > Reviewed-by: Orit Wasserman > Reviewed-by: Juan Quintela > Signed-off-by: Paolo Bonzini > Signed-off-by: Juan Quintela > Should we add these patches to qemu-stable? 5da5aad (migration: simplify while loop, 2013-02-22) 891518a (migration: always use vm_stop_force_state, 2013-02-22) 7a2c172 (migration: move more error handling to migrate_fd_cleanup, 2013-02-22) 04943eb (migration: push qemu_savevm_state_cancel out of qemu_savevm_state_*, 2013-02-22) 93bf210 (qemu-file: pass errno from qemu_fflush via f->last_error, 2013-02-22) 47c8c17 (migration: use qemu_file_set_error to pass error codes back to qemu_savevm_state, 2013-02-22) 4eb9381 (qemu-file: temporarily expose qemu_file_set_error and qemu_fflush, 2013-02-22) f582151 (migration: flush all data to fd when buffered_flush is called, 2013-02-22) 63dfbd7 (migration: use qemu_file_set_error, 2013-02-22) dba433c (migration: simplify error handling, 2013-02-22) Paolo