From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHuEZ-0008Ly-Vo for qemu-devel@nongnu.org; Tue, 19 Mar 2013 06:57:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHuEY-0004dO-CR for qemu-devel@nongnu.org; Tue, 19 Mar 2013 06:57:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60451 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHuEY-0004dI-3w for qemu-devel@nongnu.org; Tue, 19 Mar 2013 06:57:34 -0400 Message-ID: <5148449B.7050805@suse.de> Date: Tue, 19 Mar 2013 11:57:31 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1363628865-29390-1-git-send-email-peter.maydell@linaro.org> <1363628865-29390-3-git-send-email-peter.maydell@linaro.org> <51476DD1.6070705@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/2] hw/arm_gic_common: Use vmstate struct rather than save/load functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mitsyanko Cc: Michael Roth , Peter Maydell , Gerd Hoffmann , qemu-devel@nongnu.org, patches@linaro.org Am 18.03.2013 21:43, schrieb Igor Mitsyanko: >=20 > On Mar 19, 2013 12:21 AM, "Peter Maydell" > wrote: >> >> On 18 March 2013 19:48, Igor Mitsyanko > wrote: >> >> On 03/18/2013 09:47 PM, Peter Maydell wrote: >> >>> >> >>> + VMSTATE_BUFFER_UNSAFE(last_active, GICState, 0, >> >>> + GIC_MAXIRQ * NCPU * sizeof(uint16_t= )), >> >> > I'm not sure about this one, do we have any guarantees that it will > always >> > be tightly packed? What will happen when we will try to migrate VM > between >> > BE and LE hosts? >> >> Ugh. I think the packing is ok but I hadn't thought about the >> endianness issue. >> >> Gerd and I were talking on IRC about 2D arrays. I think we came to >> the conclusion that you could provide a new set of vmstate macros >> for 2D arrays which basically work just like the existing 1D array >> ones except that the typecheck is different. >> >> (vmstate.h is getting hugely repetitive to the point that I'm >> really tempted to say we should just autogenerate it. That way >> you could define a fairly small set of things (arrays, base types, >> safe vs unsafe, etc) and have a script generate the cross product, >> rather than the current setup where there is a lot of hand written >> repetition and a tendency to gaps in the coverage where nobody's >> using them yet.) >> >> -- PMM >=20 > I can recall a qemu-devel discussion over a long-term QOM goals a while > ago.Somebody suggested that in the future we will define devices state > structures using some special macro which will be parsed during > compilation, serializing each member for both QOM introspection and > vmstate migration. QIDL - CC'ing Michael. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg