qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing
Date: Tue, 19 Mar 2013 12:18:02 +0100	[thread overview]
Message-ID: <5148496A.3050201@redhat.com> (raw)
In-Reply-To: <87a9pzojr5.fsf@blackfin.pond.sub.org>

Il 19/03/2013 09:51, Markus Armbruster ha scritto:
> Paolo, please have a look.

Why isn't it enough to call bdrv_init_with_whitelist earlier?

There is no conditional logic in it, the whitelist is checked at open time.

Paolo

> Peter Lieven <pl@kamp.de> writes:
> 
>> current git master segfaults if an iscsi option is specified
>> in command line.
>>
>> Peter Lieven (2):
>>   qemu-option: avoid segfault if QemuOptsList == NULL
>>   vl.c: fix segfault in iscsi options parsing
>>
>>  block/iscsi.c      |   27 ---------------------------
>>  util/qemu-option.c |    1 +
>>  vl.c               |   40 +++++++++++++++++++++++++++++++++++++---
>>  3 files changed, 38 insertions(+), 30 deletions(-)
> 
> 

  reply	other threads:[~2013-03-19 11:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19  8:19 [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing Peter Lieven
2013-03-19  8:19 ` [Qemu-devel] [PATCH 1/2] qemu-option: avoid segfault if QemuOptsList == NULL Peter Lieven
2013-03-19  8:19 ` [Qemu-devel] [PATCH 2/2] vl.c: fix segfault in iscsi options parsing Peter Lieven
2013-03-19  8:51 ` [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing Markus Armbruster
2013-03-19 11:18   ` Paolo Bonzini [this message]
2013-03-19 15:54     ` Peter Lieven
2013-03-19 17:07       ` Paolo Bonzini
2013-03-19 19:37         ` Peter Lieven
2013-03-19 20:58           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5148496A.3050201@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).