From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59975) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHuYW-0007o9-Qt for qemu-devel@nongnu.org; Tue, 19 Mar 2013 07:18:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHuYR-0003QB-OF for qemu-devel@nongnu.org; Tue, 19 Mar 2013 07:18:12 -0400 Received: from mail-vc0-f178.google.com ([209.85.220.178]:55188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHuYR-0003Q4-Iv for qemu-devel@nongnu.org; Tue, 19 Mar 2013 07:18:07 -0400 Received: by mail-vc0-f178.google.com with SMTP id hz11so252313vcb.9 for ; Tue, 19 Mar 2013 04:18:07 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5148496A.3050201@redhat.com> Date: Tue, 19 Mar 2013 12:18:02 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1363681158-26122-1-git-send-email-pl@kamp.de> <87a9pzojr5.fsf@blackfin.pond.sub.org> In-Reply-To: <87a9pzojr5.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Peter Lieven , qemu-devel@nongnu.org Il 19/03/2013 09:51, Markus Armbruster ha scritto: > Paolo, please have a look. Why isn't it enough to call bdrv_init_with_whitelist earlier? There is no conditional logic in it, the whitelist is checked at open time. Paolo > Peter Lieven writes: > >> current git master segfaults if an iscsi option is specified >> in command line. >> >> Peter Lieven (2): >> qemu-option: avoid segfault if QemuOptsList == NULL >> vl.c: fix segfault in iscsi options parsing >> >> block/iscsi.c | 27 --------------------------- >> util/qemu-option.c | 1 + >> vl.c | 40 +++++++++++++++++++++++++++++++++++++--- >> 3 files changed, 38 insertions(+), 30 deletions(-) > >