From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46654)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1UHwwk-0004mB-VJ
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:51:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1UHwwg-00014a-Rw
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:51:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34881)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hdegoede@redhat.com>) id 1UHwwg-00014E-Kv
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 09:51:18 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2JDpHrF032113
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 19 Mar 2013 09:51:17 -0400
Message-ID: <51486E1D.3040301@redhat.com>
Date: Tue, 19 Mar 2013 14:54:37 +0100
From: Hans de Goede <hdegoede@redhat.com>
MIME-Version: 1.0
References: <1363279017-3894-1-git-send-email-hdegoede@redhat.com>
	<1363279017-3894-9-git-send-email-hdegoede@redhat.com>
	<51485CA3.3000206@redhat.com>
In-Reply-To: <51485CA3.3000206@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 8/8] usb-redir: Add flow control support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= <mlureau@redhat.com>, qemu-devel@nongnu.org

Hi,

Oops. v2 is on its way.

Regards,

Hans


On 03/19/2013 01:40 PM, Gerd Hoffmann wrote:
> On 03/14/13 17:36, Hans de Goede wrote:
>> +        if (!dev->watch) {
>> +            dev->watch = qemu_chr_fe_add_watch(dev->cs, G_IO_OUT,
>> +                                               usbredir_write_unblocked, dev);
>> +        }
>> +        if (r < 0)
>> +            r = 0;
>> +    }
>> +    return r;
>
> === checkpatch complains ===
> WARNING: braces {} are necessary for all arms of this statement
> #48: FILE: hw/usb/redirect.c:290:
> +        if (r < 0)
> [...]
>
> total: 0 errors, 1 warnings, 65 lines checked
>
> cheers,
>    Gerd
>