From: Stefan Berger <stefanb@linux.vnet.ibm.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V27 1/7] Support for TPM command line options
Date: Tue, 19 Mar 2013 10:49:07 -0400 [thread overview]
Message-ID: <51487AE3.7010009@linux.vnet.ibm.com> (raw)
In-Reply-To: <871ubb4g5w.fsf@blackfin.pond.sub.org>
On 03/19/2013 10:28 AM, Markus Armbruster wrote:
> Stefan Berger <stefanb@linux.vnet.ibm.com> writes:
>
>>
>> I can write an OS that sends a command to the TPM and then shuts down
>> without waiting for the program to terminate or the even the response
>> from the TPM to come back . In this case we would need to cancel the
>> command on exit()l.
> Aha, now we're getting somewhere.
>
> Are you talking about the following scenario?
>
> * Guest sends TPM command, QEMU passes it through, QEMU thread blocks in
> write() to TPM.
>
> * Guest powers down, QEMU is configured to terminate on powerdown, calls
> exit().
>
> * Unless you explicitly cancel the TPM command, $BAD_THINGS can happen.
>
> If yes, please describe at least one instance of $BAD_THINGS for me
> again.
BAD_THINGS = If a TPM command is executing as in the scenario you are
describing, the thread will still be caught in the write(), thus the
QEMU process cannot terminate and will be stuck in the thread-join as it
is implemented now. If there was no thread-join QEMU would probably
linger around as a zombie for a while.
Stefan
next prev parent reply other threads:[~2013-03-19 14:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1361987275-26289-1-git-send-email-stefanb@linux.vnet.ibm.com>
2013-03-12 21:44 ` [Qemu-devel] [PATCH V27 0/7] QEMU Trusted Platform Module (TPM) integration Anthony Liguori
[not found] ` <1361987275-26289-2-git-send-email-stefanb@linux.vnet.ibm.com>
2013-03-15 7:36 ` [Qemu-devel] [PATCH V27 1/7] Support for TPM command line options Markus Armbruster
2013-03-15 13:29 ` Stefan Berger
2013-03-18 13:10 ` Markus Armbruster
2013-03-18 13:44 ` Stefan Berger
2013-03-19 7:45 ` Markus Armbruster
2013-03-19 10:27 ` Stefan Berger
2013-03-19 14:28 ` Markus Armbruster
2013-03-19 14:49 ` Stefan Berger [this message]
2013-03-15 15:49 ` Corey Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51487AE3.7010009@linux.vnet.ibm.com \
--to=stefanb@linux.vnet.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).