From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
xen-devel <xen-devel@lists.xen.org>,
Alex Bligh <alex@alex.org.uk>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.
Date: Tue, 19 Mar 2013 17:53:44 +0100 [thread overview]
Message-ID: <51489818.9040709@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1303191454170.4716@kaball.uk.xensource.com>
Il 19/03/2013 16:13, Stefano Stabellini ha scritto:
> This patch only impacts the PV backend in QEMU, not the IDE interface.
> PV frontends and backends always disconnect and reconnect during
> save/restore.
> So we can be *certain* that bdrv_close at the sender side is called
> before the new connection is established at the receiver side.
>From the little I remember about Xen, they go to XenbusStateClosed on
the source before invoking the suspend hypercall? And then restart on
the destination?
If so, that sounds right. Thanks for finding an elegant solution.
> Unfortunately the QEMU PV backend opens the disk during initialization,
> so before the actual connection is established (blk_init).
>
> Therefore I think that the current change is not safe, but it is pretty
> easy to make it safe.
> You just need to move the call to blk_open from blk_init to blk_connect.
Paolo
next prev parent reply other threads:[~2013-03-19 16:54 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 12:18 [Qemu-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes Alex Bligh
2013-03-18 13:03 ` Stefan Hajnoczi
2013-03-18 13:19 ` Alex Bligh
2013-03-18 13:32 ` Paolo Bonzini
2013-03-18 13:49 ` Alex Bligh
2013-03-18 14:05 ` Paolo Bonzini
2013-03-18 14:30 ` Alex Bligh
2013-03-18 14:49 ` Paolo Bonzini
2013-03-18 15:40 ` Alex Bligh
2013-03-18 16:19 ` Paolo Bonzini
2013-03-18 16:53 ` Alex Bligh
2013-03-18 17:38 ` George Dunlap
2013-03-18 17:47 ` Alex Bligh
2013-03-18 18:00 ` Paolo Bonzini
2013-03-19 10:06 ` [Qemu-devel] [Xen-devel] " George Dunlap
2013-03-19 10:43 ` Paolo Bonzini
2013-03-19 10:51 ` George Dunlap
2013-03-19 11:14 ` Paolo Bonzini
2013-03-19 11:21 ` George Dunlap
2013-03-19 15:12 ` George Dunlap
2013-03-19 15:29 ` George Dunlap
2013-03-19 19:15 ` Alex Bligh
2013-03-20 10:24 ` Stefano Stabellini
2013-03-20 10:37 ` George Dunlap
2013-03-20 11:08 ` Paolo Bonzini
2013-03-20 11:20 ` Alex Bligh
2013-03-20 11:57 ` David Scott
2013-03-19 11:44 ` Alex Bligh
2013-03-19 11:49 ` Paolo Bonzini
2013-03-19 15:13 ` Stefano Stabellini
2013-03-19 16:53 ` Paolo Bonzini [this message]
2013-03-19 17:03 ` Stefano Stabellini
2013-03-20 8:33 ` Alex Bligh
2013-03-20 9:26 ` Paolo Bonzini
2013-03-29 17:19 ` Stefano Stabellini
2013-03-31 19:53 ` Alex Bligh
2013-04-01 15:32 ` [Qemu-devel] [PATCH] [RFC] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect Alex Bligh
2013-04-01 15:44 ` Stefano Stabellini
2013-04-01 20:56 ` Alex Bligh
2013-04-02 11:08 ` Stefano Stabellini
2013-04-05 10:31 ` [Qemu-devel] [PATCHv2 1/2] " Alex Bligh
2013-04-05 10:31 ` [Qemu-devel] [PATCHv2 2/2] Xen PV backend: Disable use of O_DIRECT by default as it results in crashes Alex Bligh
2013-04-05 14:22 ` [Qemu-devel] [PATCHv2 1/2] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect Stefano Stabellini
2013-04-05 15:42 ` [Qemu-devel] [PATCHv3 " Alex Bligh
2013-04-05 15:42 ` [Qemu-devel] [PATCHv3 2/2] Xen PV backend: Disable use of O_DIRECT by default as it results in crashes Alex Bligh
2013-04-05 15:43 ` [Qemu-devel] [PATCHv2 1/2] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect Alex Bligh
2013-04-05 10:32 ` [Qemu-devel] [PATCHv2 1/2] Xen PV backend (for qemu-upstream-4.2-testing): " Alex Bligh
2013-04-05 10:32 ` [Qemu-devel] [PATCHv2 2/2] Xen PV backend (for qemu-upstream-4.2-testing): Disable use of O_DIRECT by default as it results in crashes Alex Bligh
2013-04-05 10:34 ` [Qemu-devel] [PATCH] [RFC] Xen PV backend: Move call to bdrv_new from blk_init to blk_connect Alex Bligh
2013-04-01 16:35 ` [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes Alex Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51489818.9040709@redhat.com \
--to=pbonzini@redhat.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=alex@alex.org.uk \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).