From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38693)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UI00d-0005Te-D1
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 13:07:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UI00c-0000cq-2Y
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 13:07:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:3730)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UI00b-0000ch-RQ
	for qemu-devel@nongnu.org; Tue, 19 Mar 2013 13:07:34 -0400
Message-ID: <51489B4B.6050601@redhat.com>
Date: Tue, 19 Mar 2013 18:07:23 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1363681158-26122-1-git-send-email-pl@kamp.de>
	<87a9pzojr5.fsf@blackfin.pond.sub.org>
	<5148496A.3050201@redhat.com> <51488A1F.1080401@kamp.de>
In-Reply-To: <51488A1F.1080401@kamp.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org

Il 19/03/2013 16:54, Peter Lieven ha scritto:
> On 19.03.2013 12:18, Paolo Bonzini wrote:
>> Il 19/03/2013 09:51, Markus Armbruster ha scritto:
>>> Paolo, please have a look.
>> Why isn't it enough to call bdrv_init_with_whitelist earlier?
>>
>> There is no conditional logic in it, the whitelist is checked at open
>> time.
> 
> Has anyone tested if -spice is working?

It is.

machine_init entries are processed just below the other qemu_add_opts.

Paolo

 In this case
> bdrv_init_with_whitelist() won't help here.
> 
> Anyway, I would like to change the -iscsi code in vl.c to throw an
> error, if iscsi support is not
> compiled in (like it is done with spice).
> 
> Peter
> 
>>
>> Paolo
>>
>>> Peter Lieven <pl@kamp.de> writes:
>>>
>>>> current git master segfaults if an iscsi option is specified
>>>> in command line.
>>>>
>>>> Peter Lieven (2):
>>>>    qemu-option: avoid segfault if QemuOptsList == NULL
>>>>    vl.c: fix segfault in iscsi options parsing
>>>>
>>>>   block/iscsi.c      |   27 ---------------------------
>>>>   util/qemu-option.c |    1 +
>>>>   vl.c               |   40 +++++++++++++++++++++++++++++++++++++---
>>>>   3 files changed, 38 insertions(+), 30 deletions(-)
>>>
> 
>