From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI1L7-0008FO-My for qemu-devel@nongnu.org; Tue, 19 Mar 2013 14:32:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UI1L5-0001oE-0p for qemu-devel@nongnu.org; Tue, 19 Mar 2013 14:32:49 -0400 Sender: Richard Henderson Message-ID: <5148AF42.7000103@twiddle.net> Date: Tue, 19 Mar 2013 11:32:34 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1363694598-19799-1-git-send-email-chouteau@adacore.com> <1F098328-BA3A-40BC-955B-9CDFF470D257@suse.de> <514880BD.8040009@adacore.com> <51489E47.5040204@adacore.com> In-Reply-To: <51489E47.5040204@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabien Chouteau Cc: Peter Maydell , qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org On 03/19/2013 10:20 AM, Fabien Chouteau wrote: > Cleaner solution indeed. I'll do the opposite, store_fpscr calls helper_store_fpscr. The declarations won't be in the right places for that to work right. Canonically, cpu_store_fpscr should be declared in cpu.h, have the leading "cpu_" prefix, and then helper_store_fpscr is declared (via macro) in helper.h and its definition should call the cpu.h function. r~