From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 02/11] block: Pass bdrv_file_open() options to block drivers
Date: Tue, 19 Mar 2013 13:37:21 -0600 [thread overview]
Message-ID: <5148BE71.6010701@redhat.com> (raw)
In-Reply-To: <20130319180533.GG2418@dhcp-200-207.str.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]
On 03/19/2013 12:05 PM, Kevin Wolf wrote:
> Am 19.03.2013 um 18:48 hat Eric Blake geschrieben:
>> On 03/18/2013 11:23 AM, Kevin Wolf wrote:
>>> Specify -drive file.option=... on the command line to pass the option to
>>> the protocol instead of the format driver.
>>>
>>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>>> ---
>>> block.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------
>>> 1 file changed, 56 insertions(+), 7 deletions(-)
>>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>
>> Still hoping we expose this in QMP for hotplug, but I'll see how things
>> go through the series...
>
> We'll get there, but I can't do everything at once. So my plan is to
> complete the command line extensions first and only then get to QMP. I'm
> almost sure that we're thinking of very similar things that we want to
> have as the final result, but one step after another.
Not a problem - just hoping that we can get there in time for 1.5. I'm
happy to review these types of patches, since it directly affects
interfaces that libvirt will want to use.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-03-19 19:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-18 17:23 [Qemu-devel] [PATCH 00/11] block: Driver-specific options for protocols Kevin Wolf
2013-03-18 17:23 ` [Qemu-devel] [PATCH 01/11] block: Add options QDict to bdrv_file_open() prototypes Kevin Wolf
2013-03-19 15:40 ` Eric Blake
2013-03-18 17:23 ` [Qemu-devel] [PATCH 02/11] block: Pass bdrv_file_open() options to block drivers Kevin Wolf
2013-03-19 17:48 ` Eric Blake
2013-03-19 18:05 ` Kevin Wolf
2013-03-19 19:37 ` Eric Blake [this message]
2013-03-18 17:23 ` [Qemu-devel] [PATCH 03/11] qemu-socket: Make socket_optslist public Kevin Wolf
2013-03-19 19:51 ` Eric Blake
2013-03-18 17:23 ` [Qemu-devel] [PATCH 04/11] nbd: Keep hostname and port separate Kevin Wolf
2013-03-19 20:56 ` Eric Blake
2013-03-18 17:23 ` [Qemu-devel] [PATCH 05/11] nbd: Remove unused functions Kevin Wolf
2013-03-19 20:58 ` Eric Blake
2013-03-18 17:23 ` [Qemu-devel] [PATCH 06/11] nbd: Accept -drive options for the network connection Kevin Wolf
2013-03-19 21:44 ` Eric Blake
2013-03-18 17:23 ` [Qemu-devel] [PATCH 07/11] block: Introduce .bdrv_parse_filename callback Kevin Wolf
2013-03-19 22:04 ` Eric Blake
2013-03-18 17:23 ` [Qemu-devel] [PATCH 08/11] block: Rename variable to avoid shadowing Kevin Wolf
2013-03-20 2:07 ` Eric Blake
2013-03-20 8:51 ` Kevin Wolf
2013-03-18 17:23 ` [Qemu-devel] [PATCH 09/11] block: Make find_image_format safe with NULL filename Kevin Wolf
2013-03-20 2:14 ` Eric Blake
2013-03-20 8:48 ` Kevin Wolf
2013-03-18 17:24 ` [Qemu-devel] [PATCH 10/11] block: Allow omitting the file name when using driver-specific options Kevin Wolf
2013-03-20 2:27 ` Eric Blake
2013-03-20 18:37 ` Kevin Wolf
2013-03-18 17:24 ` [Qemu-devel] [PATCH 11/11] nbd: Use default port if only host is specified Kevin Wolf
2013-03-20 2:29 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5148BE71.6010701@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).