From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI3cO-0006a3-Vf for qemu-devel@nongnu.org; Tue, 19 Mar 2013 16:58:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UI3cK-0007QF-Az for qemu-devel@nongnu.org; Tue, 19 Mar 2013 16:58:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI3cK-0007Py-47 for qemu-devel@nongnu.org; Tue, 19 Mar 2013 16:58:44 -0400 Message-ID: <5148D17A.7040108@redhat.com> Date: Tue, 19 Mar 2013 21:58:34 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1363681158-26122-1-git-send-email-pl@kamp.de> <87a9pzojr5.fsf@blackfin.pond.sub.org> <5148496A.3050201@redhat.com> <51488A1F.1080401@kamp.de> <51489B4B.6050601@redhat.com> <9740AF0E-CF0D-4C46-BB56-4E0A60FE40BE@kamp.de> In-Reply-To: <9740AF0E-CF0D-4C46-BB56-4E0A60FE40BE@kamp.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: Markus Armbruster , qemu-devel@nongnu.org Il 19/03/2013 20:37, Peter Lieven ha scritto: > > Am 19.03.2013 um 18:07 schrieb Paolo Bonzini : > >> Il 19/03/2013 16:54, Peter Lieven ha scritto: >>> On 19.03.2013 12:18, Paolo Bonzini wrote: >>>> Il 19/03/2013 09:51, Markus Armbruster ha scritto: >>>>> Paolo, please have a look. >>>> Why isn't it enough to call bdrv_init_with_whitelist earlier? >>>> >>>> There is no conditional logic in it, the whitelist is checked at open >>>> time. >>> >>> Has anyone tested if -spice is working? >> >> It is. >> >> machine_init entries are processed just below the other qemu_add_opts. > > Ok, if you agree I would prepare a new version of this patch set with 3 patches: > > 1) move up brd_init_with_whitelist > 2) throw an error if -iscsi is used without compile libiscsi support > 3) assert that QemuOptsList != NULL to avoid further segfaults. > > I currently see a segfault on VM start in libiscsi with latest git. Whereas my old > qemu-kvm 1.2.0 is working with the same command line and libiscsi library. > As soon as I have sorted this out I will send a new patch set. I don't think (3) is that important, but yes, that's the plan. Paolo