From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI8R0-0007Wp-0s for qemu-devel@nongnu.org; Tue, 19 Mar 2013 22:07:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UI8Qu-00029i-RE for qemu-devel@nongnu.org; Tue, 19 Mar 2013 22:07:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UI8Qu-00029Z-IE for qemu-devel@nongnu.org; Tue, 19 Mar 2013 22:07:16 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2K27FgA014940 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Mar 2013 22:07:16 -0400 Message-ID: <514919D2.5050403@redhat.com> Date: Tue, 19 Mar 2013 20:07:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363627441-8297-1-git-send-email-kwolf@redhat.com> <1363627441-8297-9-git-send-email-kwolf@redhat.com> In-Reply-To: <1363627441-8297-9-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2TVGOBEGVMHARJNJIUPMG" Subject: Re: [Qemu-devel] [PATCH 08/11] block: Rename variable to avoid shadowing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2TVGOBEGVMHARJNJIUPMG Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/18/2013 11:23 AM, Kevin Wolf wrote: > bdrv_open() uses two different variables called options. Rename one of > them to avoid confusion and to allow the outer one to be accessed > everywhere. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) Reviewed-by: Eric Blake Should configure be setting up -Wshadow to help prevent instances like th= is? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2TVGOBEGVMHARJNJIUPMG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRSRnSAAoJEKeha0olJ0Nq9rwH/0GZ6tH1/EHTJlPfjm+C4etJ Xzy2wep4ltX4ajO17T10VUnH4FlmOxuSqx7dwTMrvVOLiWwwTPJSbqt9tW1x7xeF J9iJ6MP6A2CrPNbWiJL3aaK8fyWlJKETXp0Rj5YphC3CZG6CyIW9VFkdYyb+GAKi v52dPGj09WAMqg+cwHfNiJ7nkcVpvtZ9B8z30ph9PnGKHdFbJNUJ0ikCxlBlzhB2 rmXPmRdwgyYUbc88Jj2L6TSpAzYU57BeWH5utFWytr+SpyVQ9tDfXcR5F6qtNQwq DAyfzRMlJFHMerbCKGA9hlX9sPYHbQdof7/QLAEg2v+BebuIk1x+ArROGdCo/QY= =l4C6 -----END PGP SIGNATURE----- ------enig2TVGOBEGVMHARJNJIUPMG--