Re: [Qemu-devel] [PATCH 11/11] nbd: Use default port if only host is specified

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

On 03/18/2013 11:24 AM, Kevin Wolf wrote:
> The URL method already takes care to apply the default port when none is
> specfied. Directly specifying driver-specific options required the port
> number until now. Allow leaving it out and apply the default.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/nbd.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/block/nbd.c b/block/nbd.c
> index 218df6a..ac61b6d 100644
> --- a/block/nbd.c
> +++ b/block/nbd.c
> @@ -119,20 +119,17 @@ static int nbd_parse_uri(const char *filename, QDict *options)
>          qdict_put(options, "path", qstring_from_str(qp->p[0].value));
>      } else {
>          /* nbd[+tcp]://host:port/export */

Should this comment be rewritten as:

/* nbd[+tcp]://host[:port]/export */

But that's trivial, so:

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]