From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIM0D-0002Y7-Ly for qemu-devel@nongnu.org; Wed, 20 Mar 2013 12:36:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIM08-0005Su-QK for qemu-devel@nongnu.org; Wed, 20 Mar 2013 12:36:37 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:44570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIM08-0005SZ-J3 for qemu-devel@nongnu.org; Wed, 20 Mar 2013 12:36:32 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 20 Mar 2013 10:36:31 -0600 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 2B27BC9001A for ; Wed, 20 Mar 2013 12:36:27 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2KGaRNJ303516 for ; Wed, 20 Mar 2013 12:36:27 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2KGaQIg003166 for ; Wed, 20 Mar 2013 12:36:26 -0400 Message-ID: <5149E58A.3010309@linux.vnet.ibm.com> Date: Wed, 20 Mar 2013 12:36:26 -0400 From: Corey Bryant MIME-Version: 1.0 References: <1363367835-11306-1-git-send-email-coreyb@linux.vnet.ibm.com> In-Reply-To: <1363367835-11306-1-git-send-email-coreyb@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: lcapitulino@redhat.com, armbru@redhat.com Cc: qemu-devel@nongnu.org, stefanb@linux.vnet.ibm.com I just resubmitted this patch as part of another series, so please ignore this one. -- Regards, Corey Bryant On 03/15/2013 01:17 PM, Corey Bryant wrote: > Signed-off-by: Corey Bryant > --- > qemu-options.hx | 3 ++- > qmp-commands.hx | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 61 insertions(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 30fb85d..3b3cd0f 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2237,7 +2237,8 @@ Backend type must be: > @option{passthrough}. > > The specific backend type will determine the applicable options. > -The @code{-tpmdev} option requires a @code{-device} option. > +The @code{-tpmdev} option creates the TPM backend and requires a > +@code{-device} option that specifies the TPM frontend interface model. > > Options to each backend are described below. > > diff --git a/qmp-commands.hx b/qmp-commands.hx > index b370060..4eda5ea 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -2721,18 +2721,77 @@ EQMP > .mhandler.cmd_new = qmp_marshal_input_query_tpm, > }, > > +SQMP > +query-tpm > +--------- > + > +Return information about the TPM device. > + > +Arguments: None > + > +Example: > + > +-> { "execute": "query-tpm" } > +<- { "return": > + [ > + { "model": "tpm-tis", > + "tpm-options": > + { "type": "tpm-passthrough-options", > + "data": > + { "cancel-path": "/sys/class/misc/tpm0/device/cancel", > + "path": "/dev/tpm0" > + } > + }, > + "type": "passthrough", > + "id": "tpm0" > + } > + ] > + } > + > +EQMP > + > { > .name = "query-tpm-models", > .args_type = "", > .mhandler.cmd_new = qmp_marshal_input_query_tpm_models, > }, > > +SQMP > +query-tpm-models > +---------------- > + > +Return a list of supported TPM models. > + > +Arguments: None > + > +Example: > + > +-> { "execute": "query-tpm-models" } > +<- { "return": [ "tpm-tis" ] } > + > +EQMP > + > { > .name = "query-tpm-types", > .args_type = "", > .mhandler.cmd_new = qmp_marshal_input_query_tpm_types, > }, > > +SQMP > +query-tpm-types > +--------------- > + > +Return a list of supported TPM types. > + > +Arguments: None > + > +Example: > + > +-> { "execute": "query-tpm-types" } > +<- { "return": [ "passthrough" ] } > + > +EQMP > + > { > .name = "chardev-add", > .args_type = "id:s,backend:q", >