From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIQe7-0004E4-De for qemu-devel@nongnu.org; Wed, 20 Mar 2013 17:34:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIQe3-0002yu-OE for qemu-devel@nongnu.org; Wed, 20 Mar 2013 17:34:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16832) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIQe3-0002yo-F4 for qemu-devel@nongnu.org; Wed, 20 Mar 2013 17:34:03 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r2KLY2EE027236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 20 Mar 2013 17:34:02 -0400 Message-ID: <514A2B4A.1050804@redhat.com> Date: Wed, 20 Mar 2013 15:34:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363804788-18535-1-git-send-email-kwolf@redhat.com> <1363804788-18535-13-git-send-email-kwolf@redhat.com> In-Reply-To: <1363804788-18535-13-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2WLQTCBCJRSOSJIBFIDSH" Subject: Re: [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option combinations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2WLQTCBCJRSOSJIBFIDSH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/20/2013 12:39 PM, Kevin Wolf wrote: > A file name may only specified if no host or socket path is specified. > The latter two may not appear at the same time either. >=20 > Signed-off-by: Kevin Wolf > --- > block/nbd.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Reviewed-by: Eric Blake I'm assuming that the rest of the series is unchanged, on the commits where you carried forward my v1 review. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2WLQTCBCJRSOSJIBFIDSH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRSitKAAoJEKeha0olJ0NqGK0IAJSTKtIMUwgi7717P1HAKQoD eWbXf0V/vA5UPMU3DnFBvIfo0P3WQMqtuYTERV9YO0NTTPjpp6MSAT5MTdAwkcTM C9c2DNDmCg3RySFXYSFAeZOAJxDImqqLb19wpOJ8iogij2FxLIsMk7xmJikzFgU6 JBSP0IzNNifv6WDrX+aZhp+XRyHEm2lOHW6ZnlTS06nwViUY/fJirA89H6fz1pec o/VH3FSFCebH00SglDvK1YeL2/cuj48geFWhYLJkx3+r7vbHrp6DmCdKQEwG2e6f lNJq1jvHX6evWWm25GkD+Ginuj9KVhCSD2nqvAc3ZifMV8NaHZMgBd/VOz9S1M4= =YIM9 -----END PGP SIGNATURE----- ------enig2WLQTCBCJRSOSJIBFIDSH--