qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc: armbru@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org,
	stefanb@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 1/2] QMP: Remove duplicate TPM type from query-tpm
Date: Wed, 20 Mar 2013 15:37:37 -0600	[thread overview]
Message-ID: <514A2C21.5020502@redhat.com> (raw)
In-Reply-To: <1363797289-5865-1-git-send-email-coreyb@linux.vnet.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

On 03/20/2013 10:34 AM, Corey Bryant wrote:
> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
> ---
>  hmp.c            |    8 ++++----
>  qapi-schema.json |   12 ++++--------
>  tpm/tpm.c        |    9 ++++-----
>  3 files changed, 12 insertions(+), 17 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

Safe to do now, because 1.5 isn't released; and advisable to take before
we calcify an interface we don't like.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

  parent reply	other threads:[~2013-03-20 21:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-20 16:34 [Qemu-devel] [PATCH 1/2] QMP: Remove duplicate TPM type from query-tpm Corey Bryant
2013-03-20 16:34 ` [Qemu-devel] [PATCH 2/2] QMP: TPM QMP and man page documentation updates Corey Bryant
2013-03-20 21:39   ` Eric Blake
2013-03-21  7:21   ` Markus Armbruster
2013-03-20 21:37 ` Eric Blake [this message]
2013-03-21  7:19 ` [Qemu-devel] [PATCH 1/2] QMP: Remove duplicate TPM type from query-tpm Markus Armbruster
2013-03-21 12:25 ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514A2C21.5020502@redhat.com \
    --to=eblake@redhat.com \
    --cc=armbru@redhat.com \
    --cc=coreyb@linux.vnet.ibm.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).