From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIShJ-0000fL-9x for qemu-devel@nongnu.org; Wed, 20 Mar 2013 19:45:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIShI-0002U9-23 for qemu-devel@nongnu.org; Wed, 20 Mar 2013 19:45:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25183) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIShH-0002U4-QK for qemu-devel@nongnu.org; Wed, 20 Mar 2013 19:45:31 -0400 Message-ID: <514A4A1A.6000105@redhat.com> Date: Wed, 20 Mar 2013 17:45:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1363821803-3380-1-git-send-email-lersek@redhat.com> <1363821803-3380-5-git-send-email-lersek@redhat.com> In-Reply-To: <1363821803-3380-5-git-send-email-lersek@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2PWJOFUXCRBNIUOUEQTCN" Subject: Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: aliguori@us.ibm.com, kraxel@redhat.com, qemu-devel@nongnu.org, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2PWJOFUXCRBNIUOUEQTCN Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/20/2013 05:23 PM, Laszlo Ersek wrote: > Signed-off-by: Laszlo Ersek > --- > qapi-schema.json | 58 ++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ No counterpart change to qmp-commands.hx showing a valid usage? > 1 files changed, 58 insertions(+), 0 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index fdaa9da..aae6767 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3442,3 +3442,61 @@ > # Since: 1.5 > ## > { 'command': 'query-tpm', 'returns': ['TPMInfo'] } > + > +## > +# @AcpiTableOptions > +# > +# Specify an ACPI table on the command line to load. > +# > +# > +# @oem_id: #optional OEM identifier (6 bytes) s/oem_id/oem-id/ In general, new QMP interfaces should use '-', not '_'. > +# > +# @file: #optional colon (:) separated list of pathnames to load and > +# concatenate as table data. The resultant binary blob is expec= ted to > +# have an ACPI table header. At least one file is required. Thi= s field > +# excludes @data. > +# Ewwww. This should be '*file' : [ 'str' ] (that is, use a JSON array of file names, not a single string). If you have to reparse a JSON argument to break it into parts, then you are using the wrong interface; not to mention that I might (perversely) want to pass in a file name that contains a colon as part of its name. > +# @data: #optional colon (:) separated list of pathnames to load and > +# concatenate as table data. The resultant binary blob must not= have an > +# ACPI table header. At least one file is required. This field = excludes > +# @file. Again, JSON array, not flat string. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2PWJOFUXCRBNIUOUEQTCN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRSkoaAAoJEKeha0olJ0Nq4ogH/3cWDCDeB2ycP1W+l5EgMwaT l68BdAcFafO4Z8jWz4GXRDCv8njwiFESpi7k8VlgIhejQIAqFGhoyeeAk1jf0lBv YonZxF1hXHPmABuIwrex2ktNA6TXqZw8G7E3UxD9DGQ8YOv2E7vEF4Gs13E1pmYg Sd+1sRjYZaMkbMw+ZI9GfbSC5tTEPmaqNQDnrO9C56GqFeUjxMBifEkFl0B+SbSl /bAwzjm6K7QzugqZbsdtKrek0fl6/EyFahCMf0suVu+qG3kBFJgGuCrRnapFdNLm QWeGzaFUSGfpnUO3BOfLZwM4eB/YT/WUCej0v7SgAQnL5sxJx+RCzeZU/E3Azc4= =YSHq -----END PGP SIGNATURE----- ------enig2PWJOFUXCRBNIUOUEQTCN--