From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57826) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIcuV-0003Ns-3P for qemu-devel@nongnu.org; Thu, 21 Mar 2013 06:39:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIcuS-0005OE-65 for qemu-devel@nongnu.org; Thu, 21 Mar 2013 06:39:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIcuR-0005O6-UC for qemu-devel@nongnu.org; Thu, 21 Mar 2013 06:39:48 -0400 Message-ID: <514AE3F4.9050002@redhat.com> Date: Thu, 21 Mar 2013 11:41:56 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1363821803-3380-1-git-send-email-lersek@redhat.com> <1363821803-3380-5-git-send-email-lersek@redhat.com> <514A4A1A.6000105@redhat.com> <514A54E7.4060800@redhat.com> In-Reply-To: <514A54E7.4060800@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, kraxel@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On 03/21/13 01:31, Laszlo Ersek wrote: > On 03/21/13 00:45, Eric Blake wrote: >> On 03/20/2013 05:23 PM, Laszlo Ersek wrote: >>> +# >>> +# @oem_id: #optional OEM identifier (6 bytes) >> >> s/oem_id/oem-id/ >> >> In general, new QMP interfaces should use '-', not '_'. > > Indeed! I think this warrants a respin. Actually it doesn't, apologies -- I got confused for a minute. Again, since I aim to match the existing option format, I must keep the same spelling. Thanks, Laszlo