From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53120)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UIe2E-0007ap-7z
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 07:51:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UIe23-0001Fu-Em
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 07:51:54 -0400
Received: from mail-vc0-f178.google.com ([209.85.220.178]:56828)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UIe23-0001Fh-AQ
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 07:51:43 -0400
Received: by mail-vc0-f178.google.com with SMTP id hz11so2169803vcb.23
	for <qemu-devel@nongnu.org>; Thu, 21 Mar 2013 04:51:42 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <514AF446.4020004@redhat.com>
Date: Thu, 21 Mar 2013 12:51:34 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1363821803-3380-1-git-send-email-lersek@redhat.com>
	<1363821803-3380-5-git-send-email-lersek@redhat.com>
	<514A4A1A.6000105@redhat.com> <514A54E7.4060800@redhat.com>
	<514AE3F4.9050002@redhat.com>
In-Reply-To: <514AE3F4.9050002@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: aliguori@us.ibm.com, mst@redhat.com, kraxel@redhat.com, qemu-devel@nongnu.org

Il 21/03/2013 11:41, Laszlo Ersek ha scritto:
> On 03/21/13 01:31, Laszlo Ersek wrote:
>> On 03/21/13 00:45, Eric Blake wrote:
>>> On 03/20/2013 05:23 PM, Laszlo Ersek wrote:
> 
>>>> +#
>>>> +# @oem_id: #optional OEM identifier (6 bytes)
>>>
>>> s/oem_id/oem-id/
>>>
>>> In general, new QMP interfaces should use '-', not '_'.
>>
>> Indeed! I think this warrants a respin.
> 
> Actually it doesn't, apologies -- I got confused for a minute. Again,
> since I aim to match the existing option format, I must keep the same
> spelling.

We should make a list of places where we have mixed conventions, accept
both, and mass-convert to dash...

Paolo