From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36416)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UIenX-0000i0-Mn
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 08:40:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UIenV-0002JJ-0e
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 08:40:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:36808)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1UIenU-0002Hx-Os
	for qemu-devel@nongnu.org; Thu, 21 Mar 2013 08:40:44 -0400
Message-ID: <514B004B.6070800@redhat.com>
Date: Thu, 21 Mar 2013 13:42:51 +0100
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1363821803-3380-1-git-send-email-lersek@redhat.com>
	<1363821803-3380-5-git-send-email-lersek@redhat.com>
	<514A4A1A.6000105@redhat.com> <514A54E7.4060800@redhat.com>
	<514AE3F4.9050002@redhat.com> <514AF446.4020004@redhat.com>
	<20130321123607.GD32484@redhat.com>
In-Reply-To: <20130321123607.GD32484@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com, kraxel@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>

On 03/21/13 13:36, Michael S. Tsirkin wrote:
> On Thu, Mar 21, 2013 at 12:51:34PM +0100, Paolo Bonzini wrote:
>> Il 21/03/2013 11:41, Laszlo Ersek ha scritto:
>>> On 03/21/13 01:31, Laszlo Ersek wrote:
>>>> On 03/21/13 00:45, Eric Blake wrote:
>>>>> On 03/20/2013 05:23 PM, Laszlo Ersek wrote:
>>>
>>>>>> +#
>>>>>> +# @oem_id: #optional OEM identifier (6 bytes)
>>>>>
>>>>> s/oem_id/oem-id/
>>>>>
>>>>> In general, new QMP interfaces should use '-', not '_'.
>>>>
>>>> Indeed! I think this warrants a respin.
>>>
>>> Actually it doesn't, apologies -- I got confused for a minute. Again,
>>> since I aim to match the existing option format, I must keep the same
>>> spelling.
>>
>> We should make a list of places where we have mixed conventions, accept
>> both, and mass-convert to dash...
>>
>> Paolo
> 
> Anthony used to nack all mass conversions since they mess up the git
> history. Since the movement of headers went in, I gather this position
> has been relaxed...
> 

Paolo, what are you suggesting precisely?

Thanks
Laszlo