From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIetu-0005CE-1Z for qemu-devel@nongnu.org; Thu, 21 Mar 2013 08:47:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UIets-0004NI-Qj for qemu-devel@nongnu.org; Thu, 21 Mar 2013 08:47:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UIets-0004N9-JM for qemu-devel@nongnu.org; Thu, 21 Mar 2013 08:47:20 -0400 Message-ID: <514B0152.10005@redhat.com> Date: Thu, 21 Mar 2013 13:47:14 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <514AFC4E.4070804@redhat.com> <20130321123044.GA32484@redhat.com> In-Reply-To: <20130321123044.GA32484@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v9 2/3] qom: call class destructor before unparent List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Kevin Wolf , Anthony Liguori , Eduardo Habkost , libvir-list@redhat.com, Stefan Hajnoczi , Markus Armbruster , qemu-devel@nongnu.org, Gerd Hoffmann , Luiz Capitulino , afaerber@suse.de Il 21/03/2013 13:30, Michael S. Tsirkin ha scritto: > On Thu, Mar 21, 2013 at 01:25:50PM +0100, Paolo Bonzini wrote: > > Il 21/03/2013 13:07, Michael S. Tsirkin ha scritto: > > > Make sure object is valid when destructor is called. > > > > "Make sure the object still has a canonical path while the unparent > > callback is running". > > > > Otherwise, the series looks good. > > > > Worth respinning for? If it goes through the pci branch, of course not but still make the change. Otherwise, probably not. Paolo