qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	libvir-list@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v9 0/3] DEVICE_DELETED event
Date: Thu, 21 Mar 2013 13:57:33 +0100	[thread overview]
Message-ID: <514B03BD.1090907@suse.de> (raw)
In-Reply-To: <cover.1363633627.git.mst@redhat.com>

Am 21.03.2013 13:07, schrieb Michael S. Tsirkin:
> Changes from v8:
>     - reorder qom destruction so no need to change unparent 
> 
> Changes from v7:
>     - none, v7 was malformed series sent by mistake
> 
> Changes from v6:
>     - make empty event use data: {}, Markus prefers this
> 
> Changes from v5:
>     - Emit an empty event on unnamed devices in patch 1/3, as suggested by Markus
> 
> Changes from v4:
>     - Add extra triggers and extra fields as requested by Markus

Series looks good,

Reviewed-by: Andreas Färber <afaerber@suse.de>

Andreas

> 
> Changes from v3:
>     - Document that we only emit events for devices with
>       and ID, as suggested by Markus
> Changes from v2:
>     - move event toward the end of device_unparent,
>       so that parents are reported after their children,
>       as suggested by Paolo
> Changes from v1:
>     - move to device_unparent
>     - address comments by Andreas and Eric

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

      parent reply	other threads:[~2013-03-21 12:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-21 12:07 [Qemu-devel] [PATCH v9 0/3] DEVICE_DELETED event Michael S. Tsirkin
2013-03-21 12:07 ` [Qemu-devel] [PATCH v9 1/3] qdev: " Michael S. Tsirkin
2013-03-21 12:22   ` Markus Armbruster
2013-03-21 12:07 ` [Qemu-devel] [PATCH v9 2/3] qom: call class destructor before unparent Michael S. Tsirkin
2013-03-21 12:25   ` Paolo Bonzini
2013-03-21 12:30     ` Michael S. Tsirkin
2013-03-21 12:47       ` Paolo Bonzini
2013-03-21 12:07 ` [Qemu-devel] [PATCH v9 3/3] qmp: add path to device_deleted event Michael S. Tsirkin
2013-03-21 12:23   ` Markus Armbruster
2013-03-21 12:57 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=514B03BD.1090907@suse.de \
    --to=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).